Contrib.social

Address line 2 appears before name on the shipping label

Open on Drupal.org →
Created on 24 November 2023, about 1 year ago
Updated 20 March 2024, 9 months ago

Problem/Motivation

The address line 2 appears before name on the shipping label, if the user fills it. It should appear in the same position as in the address field, since otherwise this leads to unexpected behavior.

Steps to reproduce

Fill the address line 2 form element and generate a shipping label for that address.

Proposed resolution

Use a different parameter in the barcode API so that the value appears in the same position as it was entered: After address line 1.

Remaining tasks

Figure out which barcode API parameter to use.

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

🇨🇭Switzerland Lukas von Blarer

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Lukas von Blarer
  • First commit to issue fork.
  • Status changed to Needs review about 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    14 pass
  • Comment about 1 year ago →
    🇨🇭Switzerland berdir Switzerland

    So apparently we need to explicitly set personallyAddressed to TRUE/FALSE based on whether we have a company or not.

    This adjusts the logic and the kernel tests, didn't do a real test yet.

  • Status changed to Needs work 9 months ago
  • Comment 9 months ago →
    🇨🇭Switzerland Lukas von Blarer

    I think this doesn't solve the issue entirely. If I understand your approach correctly, this solves the incorrect order for non-company addresses. But the issue where the order is mixed up compared to the user input persists for company addresses. Is there a way to solve that too?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024