Drupal 10 implementation

Contacted today user "Anybody"

Hi afagioli,

thanks for your request. Please understand that I can't add maintainers upon request. But of course I'd be happy to add you as maintainer once the Drupal 10 module is present and reviewed.

I'm going to create a 2.x branch for you, so you can create a MR here, which we can merge into 2.x-dev once ready and then decide about maintainership.

Thank you :)

"I'm going to create a 2.x branch for you, so you can create a MR here, which we can merge into 2.x-dev once ready and then decide about maintainership."
Sounds good!
Thanks

2.x is ready for the MR! :)

If possible consider basing the variable names on the D7 module so a migration might be easier. But it's not a must!

Also see #3066323: D8 port → where existing work is linked, perhaps it might help you as starting point. Feel free to close that issue as duplicate once ready here.

Here's you MR :)
https://git.drupalcode.org/issue/commerce_simplenews_checkout-3416026

See "Show commands" in the issue summary to get started.

"See "Show commands" in the issue summary to get started."
taking ages to authenticate the push... something should be improved there

but, thanks so far

Evaluate please and eventually apply
Thanks

Well done @afagioli - I left some comments! :)

@afagioli was any of your work based onhttps://gitlab.com/attribute/commerce_simplenews_checkout by @Lukas von Blarer? (For credits)

Hi!
Yes, that's clearly it.
Thanks for pointing that out.
Getting code author involved: https://gitlab.com/attribute/commerce_simplenews_checkout/-/issues/1

About the title issue... not sure why you should change it.
This issue is about offering as active maintainer :) with aside issued discussed aside.

Well, I confirm the title of this issue is "Offering to co-maintain Commerce Simplenews Checkout integration"

This modules needs an active D10 maintainer. I'm proposing for this.
Every answer is welcome of course :)

@afagioli first we need to see the results in code. See https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →

Currently, I don't think the best practices are considered enough, so you'll definitely be credited once this is fixed, but I can't guarantee yet that I can grant Co-Maintainer access. Still your Drupal history and contribution is impressive, so this is not a clear "no", more a motiviation for higher code quality and best practice considerations. Please don't take this personally.

Still some left TODOs

This isn't the correct title, I guess

didn't mean the title of this issue, but was a code comment in GitLab reflected here!

#20 dunno... not sure I understand .. :)

Nobody here should never take it personally of course, @Anybody.
It's about giving this module an active maintainer.

I see you active today on this module. This is a good news itself. If you know someone interested in maintaining modules, please get her/him in. The history of this module confirms we all need more maintainers.

Thanks so far!

Invited today initial author of the Drupal 10 release.
https://gitlab.com/attribute/commerce_simplenews_checkout/-/issues/1

It would be great to have him as co-maintainer

Hi there! Thank you for reaching out to me!

All fine for me that you ported my code here. Please make sure that I receive commit authorship for it. And I'd like to declare the sponsorship for it on the project page.

Hi @Lukas von Blarer thanks! Yes of course. Could you perhaps review the code implemented in the MR by @afagioli?

Once RTBC'd I'm willing to merge it.

Right now I can't do a full review of the MR. Is there a way to get a diff of my module? That way I could reply to changes.