- 🇦🇺Australia mstrelan
@nicxvan they seem like dupes, haven't looked how much overlap there is.
Should there be a separate issue to move the form?
If we move the form do we then also move the route, permission and menu links? I don't think there is a yaml equivalent for these outside of modules. Is there some other issue to facilitate those things? I think probably it needs to stay where it is.
- 🇺🇸United States nicxvan
I think this is related: https://www.drupal.org/project/drupal/issues/3053832 📌 Refactor ModuleListForm Needs work in fact they might be duplicates.
I had moved the other one to extension api, but now I am second guessing, should this be in the extension system?
Should there be a separate issue to move the form?
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Reviewed the latest MR - we need to account for the fact that install profiles can now be uninstalled.
- 🇺🇸United States smustgrave
Looking at the proposed changes they appear to line up, gotta love autowiring cleaning up so much.
Replacing
require_once DRUPAL_ROOT . '/core/includes/install.inc'; $distribution = drupal_install_profile_distribution_name();Definitely feels like something multiple tickets have been trying to get to.
Nothing stands out.