We are seeing a significant number of the following errors in our logs:
Error: Call to a member function getTranslation() on null in Drupal\\Core\\Entity\\ContentEntityBase->hasTranslationChanges()
A contrib module is calling hasTranslationChanges on an entity (method inherited from ContentEntityBase).
By the time the method attempts to load the unchanged entity (L:1415 of ContentEntityBase) the entity has been deleted by a process running in another thread, meaning that $original === NULL. ( The race condition makes this quite challenging to reliably reproduce.)
Therefore, the call on L:1431 as follows $translation = $original->getTranslation($this->activeLangcode); results in an error.
Check if the unchanged entity could be loaded. If not, return FALSE from hasTranslationChanges. The logic being that the entity cannot have changes if it has been deleted. Normally actions (such as updated the changed timestamp on the entity) are taken as a result of hasTranslationChanges returning TRUE. Therefore, it is hoped that this change does not introduce unintended side-effects.
Create a merge request.
None.
None.
None.
To be defined.
Needs work
9.5
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Think we should investigate what is calling this function to trigger this issue. Fix the cause vs sympton
Either way it will need a test case.
Did not test for issue.