- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
So the dependency injection part looks like it's already been completed #3143087: Define accessManager property for ModulesListForm → is one point.
The other parts may still be needed so tagged for issue summary update for this ticket to be rescoped.
thanks.
- First commit to issue fork.
- 🇦🇺Australia mstrelan
While we're at it, should we add constructor property promotion and autowiring? Have put up an MR with these changes. I started some deprecation bits for passing
KeyValueStoreExpirableInterfaceinstead ofKeyValueExpirableFactoryInterfacebut if that's not required I won't bother polishing it. Then we wouldn't need the Autowire attribute either. - 🇦🇺Australia mstrelan
Removed the deprecation bits because as per the IS forms are not API, and I found exactly one contrib module extending this one - https://git.drupalcode.org/project/acquia_migrate/-/blob/1.9.x/src/Form/...
- 🇺🇸United States smustgrave
Can the summary be updated to include whats being done