Clean up ModuleListForm a bit

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

So the dependency injection part looks like it's already been completed #3143087: Define accessManager property for ModulesListForm → is one point.

The other parts may still be needed so tagged for issue summary update for this ticket to be rescoped.

thanks.

While we're at it, should we add constructor property promotion and autowiring? Have put up an MR with these changes. I started some deprecation bits for passing KeyValueStoreExpirableInterface instead of KeyValueExpirableFactoryInterface but if that's not required I won't bother polishing it. Then we wouldn't need the Autowire attribute either.

Removed the deprecation bits because as per the IS forms are not API, and I found exactly one contrib module extending this one - https://git.drupalcode.org/project/acquia_migrate/-/blob/1.9.x/src/Form/...

Can the summary be updated to include whats being done

Looking at the proposed changes they appear to line up, gotta love autowiring cleaning up so much.

Replacing

require_once DRUPAL_ROOT . '/core/includes/install.inc';
    $distribution = drupal_install_profile_distribution_name();

Definitely feels like something multiple tickets have been trying to get to.

Nothing stands out.

Reviewed the latest MR - we need to account for the fact that install profiles can now be uninstalled.

I think this is related: https://www.drupal.org/project/drupal/issues/3053832 📌 Refactor ModuleListForm Needs work in fact they might be duplicates.

I had moved the other one to extension api, but now I am second guessing, should this be in the extension system?

Should there be a separate issue to move the form?

@nicxvan they seem like dupes, haven't looked how much overlap there is.

Should there be a separate issue to move the form?

If we move the form do we then also move the route, permission and menu links? I don't think there is a yaml equivalent for these outside of modules. Is there some other issue to facilitate those things? I think probably it needs to stay where it is.