Deprecate ModuleHandlerInterface::*Deprecated() in favor of hook metadata

Well, hook_hook_info is now deprecated is there another way to do this?

I don't see anyway to do this now that we don't have hook hook info.

I think invocation time is the way to do it anyway.

I understand the idea and generally it makes sense, but at a glance, a few things jump out to me as awkward:

a) the location of the attribute. Putting them on a hooks class seems weird. What if your module doesn't implement any hooks? This would be different if we'd have explicit Hook attribute classes, then we could deprecate those, which would also directly expose that information to anyone using those hooks (assuming that IDE's have a concept of deprecated attributes). Attributes are great because it allows you to add metadata next to the actual thing, but there is no thing here. Maybe this could use a yaml file, but that brings me to the second point.

b) Dynamic hooks. What if we deprecate hook_form_FORM_ID_alter(), or hook_ENTITY_TYPE_load()? What if only _some_ of those are deprecated? Lets say we deprecate hook_form_BASE_FORM_ID_alter() but not hook_form_FORM_ID_alter()? Even if we'd support regex or wildcard, this will be imperfect and will possibly flag certain hooks incorrectly as deprecated that aren't.

Thank you for taking a look.

I had considered this.

a) yes I understand, but those issues exist with the current method as well with two added problems that this solves.
1 you can deprecate without using module handler.
2 It keeps the hook metadata in attributes extending a pattern that will get more familiar. Creating an empty class isn't a huge burden, I did that for the core hook deprecations.

I also think this is much nicer than yaml, you get hints when adding the attribute and you don't have to worry about indentation.

b) While this may be valid, it is an issue with the current process too, you could not independently deprecate the dynamic stacked form alters. We could likely create a custom dynamic deprecation.

In the end this cleans up an already overloaded service and gives us a cleaner way to do a rarely dive task.

One thing we might want to do is add another parameter for dynamic hooks with a pattern.

@dww on slack said we could delete the hook implementations.

I am going to delete the three implementations instead of updating the deprecation skip.

nicxvan → changed the visibility of the branch 3001190-test-cs to hidden.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.