Add a ThemeConfig service for setting and getting default and admin themes

Created on 29 January 2015, over 10 years ago
Updated 23 July 2025, 1 day ago

Problem/Motivation

ThemeHandler has a setDefault method which really is not appropriate. See #2416673-41: Add a ThemeConfig service for setting and getting default and admin themes β†’ .

Proposed resolution

  • Add a ThemeConfig service that extends a (new) ThemeConfigInterface.
  • Add methods: setDefault(), getDefault(), setAdmin() and getAdmin().
  • Mark ThemeHandler::setDefault() as deprecated.

Remaining tasks

  • Write a change record.
  • Open a follow-up issue to replace usages of config->set(), config->get() for getting and setting default and admin themes.
  • Open a follow-up issue to replace usages of ThemeHandler->setDefault() and ThemeHandler->getDefault()

User interface changes

API changes

Data model changes

Problem/Motivation

πŸ“Œ Task
Status

Needs work

Version

11.0 πŸ”₯

Component

theme system

Created by

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs change record

    A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024