Generalize MenuLinkAdd so all local actions can use it

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Maybe it's just me but if changing the class name couldn't that break existing sites?
If so we would need a different approach, maybe we deprecate the old

If not still think this could use a change record.

If so we would need a different approach, maybe we deprecate the old

I don't understand, that's exactly what the patch does.

Added a draft change notice and converted to merge request.

There was an issue in #32 in how getAsArray() was used, that is fixed now and, thus, the tests are green again. Good to go from my point of view.

Don't agree with #18.1, but other than that changes look good minus some tiny things. Left notes. Thanks for converting this @tstoeckler!

Thanks for the review, fixed all the things now (hopefully).

LGTM now. As I said before, I don't think we need \Drupal\Core\Routing\RedirectDestination::getAsArray() here because AFAIAC it doesn't make sense in this context.

I saw one seemingly random test failure, so running that one again. Can RTBC if that one goes green.

All green now.

Saving credit for Tobias, might remove some credit for broken patches but asking internally first.

• Hid all patches as we switched to MR
• Saved credit for the code contributions, leaving credit for reviews to the core committer
• Removed credit for comments that only uploaded broken patches
• On the fence about #29 as it's a tiny change but kept credit for now as it was to some extent impactful
• Will also update CR to be a bit more informative

Read the IS, comments, the MR and the Change record. For the MR, a change was requested by larowlan, which has not happened. It is explained in the comments in the MR but that should have another check, it is at https://git.drupalcode.org/project/drupal/-/merge_requests/10366#note_41.... The other was the change record which I edited to focus on the impact and what sites need to do. I put the 'what is changed' at the top, followed by the action sites may need to take. and removed bits explaining how the deprecation is done.

I also updated credit.

Filled out the issue summary template.

Added one code comment/ recommendation to the MR.

Added to the discussion regarding the wording of a test case, but don't think that warrants removing RTBC. A committer an choose between the current docs and the ones suggested on commit.

Committed b2205af and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.