In ✨ Upload the file Needs review , I tried to allow the user to upload the file containing the key. I was thinking that file upload is also an input thing, and, if you reflect a little, it really is an input. It's a way to input the key when the key provider is a file. Then I discovered that I cannot use any of the existing type plugins with my new file upload input plugin because the type plugins are hardcoding the input plugin to be used in their annotation.
Then I said, "well, I'll create my own type plugin to point to the new file upload input plugin". Hm, I realized that a file provider plugin should work with all types: encryption, authentication, authentication-multi, user-pass. Do I need to duplicate all? Ugly.
Another approach could have been to transform the key_value.plugin annotation from type plugins into a multi-value definition entry. Meaning that, for instance, the user_password could have the textarea_field and the new file upload as plugins. But, again, this would limit 3rd-party modules to add new input plugins and use the existing type plugins.
Active
1.0
Code
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.
If this change is made, Attribute support must also be changed.
Updated the 2.0 plan, I might argue that Input plugins shouldn't exist at all and instead be optional traits for KeyTypes when using the UI.