- ๐บ๐ธUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request โ as a guide.
Think a simple unit test should be added.
But moving to NW for change record and release note. - ๐ฆ๐บAustralia mstrelan
Wondering if this should actually be implementing
PluginAwareInterface
which already has asetPlugin
method. Note that the interface takes aPluginInspectionInterface
but the implementation inAction
expects a string. But, FWIW,ActionConfigEntityInterface::getPlugin
returns anActionInterface
, which extends PluginInspectionInterface, so it seems that would be a nice refactor. - ๐ฎ๐ณIndia niranjan_panem Gurugram
set plugin method is in
core/modules/system/src/Entity/Action.php
below is the document link about it. https://api.drupal.org/api/drupal/core%21modules%21system%21src%21Entity%21Action.php/function/Action%3A%3AsetPlugin/11.x - First commit to issue fork.
- ๐ฎ๐ณIndia gayathri09
This method has been removed from the interface in core 11.2.x
- ๐ฌ๐งUnited Kingdom vijaycs85 London, UK
I was working with @gayathri09 on one of the mentoring session and misunderstood the issue (Sorry gayathri09). We are still missing the
setPlugin
in interface and can't inheritdoc. I added the docbock in the MR. - ๐บ๐ธUnited States smustgrave
#28 doesnโt seem to be explored.
Summary and solution donโt line up
So moving to NW