\Drupal\system\Entity\Action::setPlugin() is missing from ActionConfigEntityInterface

Created on 2 October 2019, over 5 years ago

Updated 15 February 2023, over 2 years ago

Problem/Motivation

\Drupal\system\Entity\Action::setPlugin() is not actually part of any interface, despite that its docblock uses {@inheritdoc}.

  /**
   * {@inheritdoc}
   */
  public function setPlugin($plugin_id) {
    $this->plugin = $plugin_id;
    $this->getPluginCollection()->addInstanceId($plugin_id);
  }

Proposed resolution

Add this method to ActionConfigEntityInterface

API changes

Because there is a 1-1 relationship between \Drupal\system\Entity\Action and \Drupal\system\ActionConfigEntityInterface this is permissible in 8.x due to the Interfaces within non-experimental, non-test modules not tagged with either @api or @internal section of https://www.drupal.org/core/d8-bc-policy → .

However, we should add a change notice.

Release notes snippet

What needs to be done is there should be "setplugin()" method availabe in ActionConfigEntityInterface for mapping 1-1 with
\Drupal\system\Entity\Action.

🐛 Bug report

Status

Needs work

Version

10.1 ✨

Component

System →

Last updated 1 day ago

No maintainer

Created by

🇺🇸United States jhedstrom Portland, OR

Live updates comments and jobs are added and updated live.

Novice
It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Documentation
Primarily changes documentation, not code. For Drupal core issues, select the Documentation component instead of using this tag. In general, component selection is preferred over tag selection.

Needs change record
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Needs release note
The major change should have a special release note written to summarize the importance of the change. See Write a release note for an issue.

Bug Smash Initiative

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 2 years ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Think a simple unit test should be added.
But moving to NW for change record and release note.
Comment 12 days ago →
🇦🇺Australia mstrelan
Wondering if this should actually be implementing PluginAwareInterface which already has a setPlugin method. Note that the interface takes a PluginInspectionInterface but the implementation in Action expects a string. But, FWIW, ActionConfigEntityInterface::getPlugin returns an ActionInterface, which extends PluginInspectionInterface, so it seems that would be a nice refactor.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024