- ๐บ๐ธUnited States smustgrave
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
- ๐บ๐ธUnited States smustgrave
So should this be closed if repaired is preferred?
- ๐ณ๐ฟNew Zealand quietone
As I read it is trying to say that since
hook_update_N
has run the db is in a state where it is safe to run other updates. In that sense, 'repaired' makes sense. Although I would prefer "updated" to allow for fixes and features.For history, 'repaired' was added in #2538108: Add hook_post_update_NAME() for data value updates to reliably run after data format updates โ , at this comment โ . I did not find the word 'repair' in the issue.
- ๐ฌ๐งUnited Kingdom longwave UK
Bikeshedding: Is "bootstrapped" more descriptive than "loaded"?
- @chhavisharma opened merge request.
- ๐บ๐ธUnited States smustgrave
Title seems like this was only a document change but see code change. Should IS/title be tweaked?
- ๐บ๐ธUnited States smustgrave
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
- ๐ฎ๐ณIndia priya.chat
Hey,
Adding a patch for documentation of the return type as I'm currently facing issues with the merge request setup, so submitting this as a patch instead (though MR is the preferred method).Tried to add example for better understanding of the return type especially for entity types without bundlesโwhere the array should use an empty string ('') as the top-level key.
Please review and share feedback. Happy to revise if needed. - ๐ฎ๐ณIndia rajas samse
Hey @dom, is the current documentation in !10 sufficient, or would you like any modifications? I've followed Drupal's official README standards.
- ๐ฎ๐ณIndia rajas samse
Hi Miroslav, thanks for pointing it out!
You're right, I mistakenly based the work on 3.x instead of 4.x, not realizing 4.x is already D11-ready. The main goal was to update the documentation. Should I close this MR and open a new one targeting 4.x with just the documentation updates? Thanks
- ๐ซ๐ทFrance Dom.
Hi!
Thanks a lot for your help and review. However, Iโd like to ask for some more information about this: the MR and the issue seem to relate to the 3.x branch, which is 12 commits behind 4.x. Moreover, the 4.x version is already D11 compatible.
Could you elaborate on why you did this work specifically under 3.x?
- @rajas-samse opened merge request.
- Issue created by @rajas samse
It's from a long time ago: #2538108: Add hook_post_update_NAME() for data value updates to reliably run after data format updates โ . That issue doesn't mention "repair" any comments. I agree that "repair" seems like the wrong word.
- ๐ฎ๐ณIndia immaculatexavier
immaculatexavier โ changed the visibility of the branch 3532469-documentation-mentions-drupal to hidden.
- First commit to issue fork.
- ๐ณ๐ฟNew Zealand quietone
In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies โ . Also mentioned on the version โ section of the list of issue fields documentation.
Changing to the standard issue template โ .
Removing tag because this is already in the documentation component