- Issue created by @mradcliffe
- πΊπΈUnited States mradcliffe USA
// Most of the input-collecting methods of StyleInterface have a `default` // parameter. $arguments += [ 'default' => $default_value, ];
But not all of them do so adding default here causes the error for askHidden.
- πΊπΈUnited States mradcliffe USA
Added the Needs tests issue tag. I think the recipe.yml above could be used. We don't need to install anything. We only need to confirm the recipe is applied message is displayed to the user.
- πΊπΈUnited States mradcliffe USA
We can add a test recipe in
core/tests/fixtures/recipes
andDrupal\KernelTests\Core\Recipe\InputTest
would be a good place to either add a new kernel test? - Merge request !11743Issue #3517481: Fixes askHidden prompt in recipes β (Open) created by mradcliffe
- πΊπΈUnited States mradcliffe USA
Removes Needs tests tag after I wrote a test. Removes Documentation tag because this is not a documentation issue.
- πΊπΈUnited States smustgrave
Not as familiar with the recipe code as I'd like but looking at the summary it does line up with the MR
1) Drupal\KernelTests\Core\Recipe\InputTest::testAskHiddenPromptArgumentsForwarded Failed asserting that exception of type "Error" matches expected exception "ArgumentCountError". Message was: "Unknown named parameter $default" at /builds/issue/drupal-3517481/core/lib/Drupal/Core/Recipe/ConsoleInputCollector.php:105 /builds/issue/drupal-3517481/core/lib/Drupal/Core/Recipe/InputConfigurator.php:154 /builds/issue/drupal-3517481/core/tests/Drupal/KernelTests/Core/Recipe/InputTest.php:319 .
Shows the test coverage.
So I believe this should be good.
- π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed b43aae5dd67 to 11.x and 88dc606eba6 to 11.2.x and 8c347d75fe6 to 11.1.x. Thanks!
-
alexpott β
committed 8c347d75 on 11.1.x
Issue #3517481 by mradcliffe, smustgrave: askHidden prompt fails with "...
-
alexpott β
committed 8c347d75 on 11.1.x
-
alexpott β
committed 88dc606e on 11.2.x
Issue #3517481 by mradcliffe, smustgrave: askHidden prompt fails with "...
-
alexpott β
committed 88dc606e on 11.2.x
-
alexpott β
committed b43aae5d on 11.x
Issue #3517481 by mradcliffe, smustgrave: askHidden prompt fails with "...
-
alexpott β
committed b43aae5d on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.