- Issue created by @rkoller
- Status changed to Needs review
about 2 months ago 4:37pm 31 August 2024 - Status changed to Needs work
about 2 months ago 5:28pm 31 August 2024 - 🇩🇪Germany rkoller Nürnberg, Germany
The general direction looks fab thank you! only a few nitpicks:
Each tour consists of several tips that highlight elements of the user interface, guide the user through a workflow, or explain key concepts of the website.
one question, does guiding through a workflow mean i am able to create tours that span across several pages? meaning for example a tour for adding a field? based on the answer i might come up with a suggestion for this sentence then.
Settings form to control text
the following improvement listed is not clear what it actually refers to. instead i would suggest something like:
Settings form to control the label of the button for starting a tour
And i would remove tours from the Accessibility ecosystem. the accessibility project is about testing accessibility not being the umbrella for a11y modules in general. i would still add the tour module to the accessibility category instead. cuz if you search for the term tour within the accessibility category you only find the editoria11y checker as the sole result: https://www.drupal.org/project/project_module?f%5B0%5D=&f%5B1%5D=&f%5B2%... →
- Status changed to Needs review
about 2 months ago 7:40pm 31 August 2024 - 🇺🇸United States smustgrave
So I actually copied this from the help topics. Yes technically a workflow can be multiple pages and you can write tours for each page.
Made other changes
- 🇩🇪Germany rkoller Nürnberg, Germany
ahhh ok, but those tours on the pages a workflow spans across can't be interlinked and listed programmatically for a tour? i've rechecked the shepherd usage guide https://docs.shepherdpro.com/guides/usage/ in that regard, there is no direct indication for that feature, nor the ui of the tour module is reflecting that ability. so i wonder if the following slight simplification would make sense.
Change
Each tour consists of several tips that highlight elements of the user interface, guide the user through a workflow, or explain key concepts of the website.
toEach tour consists of several tips that highlight elements of the user interface, explaining key concepts and functionality on a page.
*I just left out the part about workflows and instead added the point that the tips are not solely about concepts but also about functionality available on a page.Aside that I've noticed three more details about the points listed in the improvements section:
Change
Integrated Tour UI to have a visual interface for creating custom tours
toIntegrated the Tour UI module to provide a visual interface for creating new and editing existing tours
*"Tour UI" might not be necessarily clear that it refers to the Tours UI module. And aside creating tours there is also the option to edit existing tours which was not possible before either.Change
Almost 4x as many default Tours
toAlmost four times as many tours available
*in regards of readability4x
is hard to skim and process. numbers smaller ten should always be written out plus the x makes the reader also think for a second what it means in that context - instead just write things out. and why not just use "available" instead of "default" and i guess tours should be lower case since it is not a title?Change
Tour block to allow tours to run without the toolbar
toThe button block for starting a tour to allow to run tours without the toolbar
...
*not necessary clear what a tour block entails. Simply adding the detail that the block contains a button to start a tour. - 🇺🇸United States smustgrave
Not a feature I plan to add. We have tours for different steps of field ui
I’ll make a few more changes but probably close this out as there other things to work on
- Status changed to Fixed
about 2 months ago 4:26pm 2 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.