When Batch ID doesn't exist, Drupal should emit a 404

I agree with #193 that this needs a code review.

added patch against #196 in 10.1 version

Hiding patch #197 as it's incomplete and omitting important changes.

Adding to the list [# https://www.drupal.org/project/site_moderators/issues/3339883] →

@Akhil Yadav, It is expected that contributors read the issue before making comments etc. The MR is against 10.1.x. I am removing credit.

bhanu951 → changed the visibility of the branch 11.x to hidden.

1 small comment on MR. Looks close

I think the test coverage is already there. Back to NR.

@bhanu951: It looks as though you updated the target of the MR to 11.x, but you never updated the feature branch.

I just rebased the feature branch on 11.x and force-pushed. That should trigger the automated tests.

NW for the failing test. See my comment on the MR for how to fix it (I think).

Also (as I said on the MR) move the test to the system module.

Thanks @benjifisher for the review, addressed your feedback.

I think it is ready for re-review.

Added a small nit, but will leave it at NR

@bhanu951:

Thanks for the updates. Now the test passes (locally and in GitLab CI). Yay!

I just have some suggestions for code cleanup on the MR. Back to NW for that.

@benjifisher : I made those changes, please re-review it. Thanks.

Hello,
Tested and verified on Drupal 11,
MR applied successfully
Working as expected
Attaching before and after screenshots-

@bhanu951:

Thanks for those final changes. I have no more suggestions.

I updated the change record. It still had the message from before the usability review in Comment #187.

I also tested manually and got something that looks a lot like the screenshot in the issue summary. (That is already up to date.)

I crossed off the last of the "Remaining tasks" in the issue summary.

@sagarmohite0031:

Thanks for the additional testing. But this issue already has up-to-date screenshots in the issue summary.

If you search for issues with the Needs screenshots → tag, you will find plenty of issues that need new screenshots. (You will probably find some that already have good screenshots, but someone forgot to remove the tag.)

Instead of uploading screenshots, it helps more to embed them. This issue is a good example: see the "before" and "after" screenshots under "User interface changes" in the issue summary. See Add screenshots to an issue → for more detailed instructions.

Committed to 11.x and backported to 11.1.x, 10.4.x and 10.5.x

Great to see this one finalized, mammoth effort over many years.

larowlan → closed merge request !3250

Automatically closed - issue fixed for 2 weeks with no activity.