Contrib.social
Created on 7 August 2024, 9 months ago

Problem/Motivation

With the recent release of Drupal 11, I would love to see some D11 support here.

Proposed Resolution

Utilize the upgrade status tool to identify deprecations and address them accordingly.

Remaining Tasks

  • File: web/modules/contrib/flexmail/modules/flexmail_webform/src/Plugin/WebformHandler/FlexmailWebformHandler.php
    Issue: Call to deprecated method getPreferences() of interface Drupal\flexmail\api\service\FlexmailApiManagerInterface: Interest labels are deprecated and superseded by Interests.


  • File: web/modules/contrib/flexmail/modules/flexmail_webform/src/Plugin/WebformHandler/FlexmailWebformHandler.php
    Issue: Call to deprecated method getInterestLabels() of interface Drupal\flexmail\api\service\FlexmailApiManagerInterface: Interest labels are deprecated and superseded by Interests.


  • File: web/modules/contrib/flexmail/src/api/service/FlexmailApiFactory.php
    Issue: Class Drupal\flexmail\api\service\FlexmailApiFactory implements deprecated interface Symfony\Component\DependencyInjection\ContainerAwareInterface: since Symfony 6.4, use dependency injection instead.


  • File: web/modules/contrib/flexmail/src/api/service/FlexmailApiFactory.php
    Issue: Usage of deprecated trait Symfony\Component\DependencyInjection\ContainerAwareTrait in class Drupal\flexmail\api\service\FlexmailApiFactory: since Symfony 6.4, use dependency injection instead.


  • File: web/modules/contrib/flexmail/flexmail.info.yml
    Issue: Value of core_version_requirement: ^9.5 || ^10 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.


  • File: web/modules/contrib/flexmail/modules/flexmail_webform/flexmail_webform.info.yml
    Issue: Value of core_version_requirement: ^9 || ^10 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.
✨ Feature request
Status

Active

Version

2.0

Component

Code

Created by

🇧🇪Belgium Jonasanne

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Jonasanne
  • Comment 9 months ago →
    🇧🇪Belgium Jonasanne
  • Issue was unassigned.
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇧🇪Belgium Jonasanne

    I have made the summarized changes. However, it still needs to be tested with a valid Flexmail account since I don't have one at the moment.

  • Comment 9 months ago →
    🇧🇪Belgium daften

    Hey Jonas,

    Can you open a MR?

    I'll ask if a team at our side could test, but could you also check on District09 side? I know there's quite a few projects using this module there :)

  • Merge request !9Issue #3466655: Add D11 support → (Open) created by Jonasanne
  • Comment 9 months ago →
    🇧🇪Belgium Jonasanne

    Hi Dieter,

    I tested everything this morning, and it all seems to be working well in one of our projects. I've also created a merge request.

    If there's anything else I need to do, please let me know.

    Best regards,

  • Comment 3 months ago →
    🇧🇪Belgium flyke

    The MR does NOT apply to 2.0.x-dev. But it does apply to 2.0.0-beta4. Should we change this issue to 'needs work' so we can work so it applies to 2.0.x-dev, or should we change the Version in this issue to 2.0.0-beta4 and set it to reviewed and tested by the community (me) ?

  • Comment 3 months ago →
    🇧🇪Belgium flyke

    I seem to have these issues now:

    Warning: Array to string conversion in Drupal\flexmail_webform\Plugin\WebformHandler\FlexmailWebformHandler->contactNeedsUpdating() (line 306 of modules/contrib/flexmail/modules/flexmail_webform/src/Plugin/WebformHandler/FlexmailWebformHandler.php).

    Warning: Array to string conversion in Drupal\flexmail_webform\Plugin\WebformHandler\FlexmailWebformHandler->contactNeedsUpdating() (line 306 of modules/contrib/flexmail/modules/flexmail_webform/src/Plugin/WebformHandler/FlexmailWebformHandler.php).

    Warning: Undefined array key "interest" in Drupal\flexmail_webform\Plugin\WebformHandler\FlexmailWebformHandler->postSave() (line 262 of modules/contrib/flexmail/modules/flexmail_webform/src/Plugin/WebformHandler/FlexmailWebformHandler.php).

  • Comment 2 months ago →
    🇧🇪Belgium Jonasanne

    @flyke
    When I check git.drupalcode.org and change the target branch to 2.0.x, it does not say anything about a merge conflict.

    Can you give me some more information about the warnings?
    Drupal version, steps to reproduce, and whether you see this warning while using these changes or without them.

  • Comment 2 months ago →
    🇧🇪Belgium Jonasanne

    uploading diff of MR as patch here.

  • Comment 2 months ago →
    🇧🇪Belgium Jonasanne

    Nevermind patch does not apply after change to target branch 2.0.x instead of 2.x.
    I'm also confused. What's the difference here and why these branch names?

  • Comment 2 months ago →
    🇧🇪Belgium Jonasanne

    New patch against 2.x

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024