Render logic not working

Created on 15 January 2025, 10 months ago

Problem/Motivation

After upgrading the module to the 2 RC1, none of the existing blocks which were placed before are rendering. This seems to come due to some questionable IF checking in the render callback of the helper class.

This seems to be only tested with custom markup blocks? As it's checking for the #markup render array which is not present in for example a BEF filter block.

Steps to reproduce

See IS

Proposed resolution

Check what exactly is going on with the conditional check which does not allow the rendering at the current moment.

Remaining tasks

MR

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @BramDriesen
  • Merge request !12Issue #3499861: Render logic not working → (Open) created by BramDriesen
  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪

    I created a quick MR to fix the issue for our use case. What I noticed:
    - When using a view (search API results) with AJAX, results are 0 when reaching the IF check
    - The #view element is not showing all settings correct, E.g. AJAX is set to false while it is enabled on the view.

  • Pipeline finished with Success
    10 months ago
    Total: 144s
    #396703
  • Status changed to Needs work 7 months ago
  • 🇧🇪Belgium Jonasanne

    We are having the same issue where results are 0 and that the render is not working correctly.
    I tested this MR and I can confirm this works.
    also uploaded diff of MR as patch.

  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪

    I guess we can set it as RTBC then

  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪

    Ah no, just checked what I did here and this is not finished

  • 🇳🇿New Zealand siramsay

    I download the patch from drupalcode repo and applied it using composer, and it fixes the issue on my site.

    Attaching patch file, I used. I guess it the same as the diff.

Production build 0.71.5 2024