- Issue created by @project update bot
- last update
about 1 year ago Patch Failed to Apply This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
about 1 year ago Not currently mergeable. - π¨π¦Canada joseph.olstad
There appears to be a mistake with the update bot suggestion, in one case it's proposing \Drupal , in the next line \\Drupal (two backspaces)
? - last update
about 1 year ago PHPLint Failed This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-137198These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.10
- palantirnet/drupal-rector: 0.20.1
- last update
about 1 year ago PHPLint Failed - last update
12 months ago PHPLint Failed - last update
12 months ago PHPLint Failed - last update
11 months ago 11 pass, 14 fail This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-188138These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.2
- Merge request !13Draft: Automated Project Update Bot fixes β (Closed) created by project update bot
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
11 months ago Not currently mergeable. The last submitted patch, 6: file_entity.2.x-dev.rector.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs review
10 months ago 12:42am 18 June 2024 - last update
10 months ago 11 pass, 14 fail This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-199781These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
- last update
10 months ago 11 pass, 14 fail The last submitted patch, 10: file_entity.2.x-dev.rector.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs review
9 months ago 5:49pm 15 July 2024 - π¨πSwitzerland berdir Switzerland
Using Gitlab UI will by default not use a commit message format that connects it back to this issue, I recommend using the UI on drupal.org, that's what I do.
Also, personally I prefer doing everything in one issue if possible, automated and manual fixes. Right now the tests are very broken, just removing the default_argument_skip_url line in default views config should fix that and then we'll see what else is left.
- π¨πSwitzerland berdir Switzerland
next major tests aren't passing, that's what I mean.
- π¨π¦Canada joseph.olstad
ok so default_argument_skip_url needs to be removed
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-229708These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.4
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
- First commit to issue fork.
- Merge request !18#3430553 additional changed which are required for D11 compatibility β (Merged) created by jrglasgow
-
joseph.olstad β
committed 95606b94 on 8.x-2.x authored by
jrglasgow β
Issue #3430553 by Project Update Bot, jrglasgow, joseph.olstad, Berdir:...
-
joseph.olstad β
committed 95606b94 on 8.x-2.x authored by
jrglasgow β
- π¨π¦Canada joseph.olstad
This can simmer in the 8.x-2.x branch for a while, the merge commit was squashed.
- Status changed to Needs work
9 months ago 12:14pm 27 July 2024 - π¨πSwitzerland berdir Switzerland
I set up a weekly scheduled next run with opt in next major and minor, which shows that lots of tests are failing on D11: https://git.drupalcode.org/project/file_entity/-/jobs/2248465.
Central file upload seems broken, which is not surprising given the file validation API changes, normalization is also broken as there were API changes there as well. See https://git.drupalcode.org/project/hal/-/commit/17001afc0e401799fee99830... for an example of changes necessary there.
phpstan is far from complete and doesn't know about quite a few things that need to be updated.
- π¨π¦Canada joseph.olstad
hmm, ok, so from what I see in the pipeline currently it's passing with:
10.2.x
10.3.xfailing with
11.0.x - Status changed to Needs review
9 months ago 9:34am 28 July 2024 - π¨πSwitzerland berdir Switzerland
Yes, but the module is now officially D11 compatible, even if it's only the dev version, people are going to enable and it's going to break stuff. IMHO, partial fixes is one thing, but IMHO D11 compatibility should only be set when all known issues are fixed and tests are passing.
It doesn't look like much is/was missing. The normalization stuff that I mentioned and a few additional validation related changes, now all tests seem to be passing on next major.
-
Berdir β
committed 95e539e8 on 8.x-2.x
Issue #3430553 by Project Update Bot, jrglasgow, joseph.olstad, Berdir:...
-
Berdir β
committed 95e539e8 on 8.x-2.x
- Status changed to Fixed
9 months ago 9:38am 28 July 2024 - π¨πSwitzerland berdir Switzerland
Removed next testing again, the scheduled pipeline can do that, and merged.
Automatically closed - issue fixed for 2 weeks with no activity.