Automated Drupal 11 compatibility fixes for password_policy

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

Looks like there are couple of tests failures and deprecations and those needs to be fixed.

chandu7929 → changed the visibility of the branch project-update-bot-only to hidden.

chandu7929 → changed the visibility of the branch project-update-bot-only to active.

ankitv18 → closed merge request !80

created a new ticket to fix phpunit previous major issue on drupal 9 - https://www.drupal.org/project/password_policy/issues/3449074 📌 PHPunit test failing for Drupal 9 Needs work

Reviewed changes and looks good to me.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.1
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.2

this is looking good to me

chandu7929 → changed the visibility of the branch 3433859-automated-drupal-11 to active.

chandu7929 → changed the visibility of the branch 3433859-automated-drupal-11 to hidden.

chandu7929 → changed the visibility of the branch 3433859-automated-drupal-11 to active.

chandu7929 → changed the visibility of the branch project-update-bot-only to hidden.

MR !84 is now ready for review, as all the work done in project update bot was removed we have cherry-picked all commit from that branch and added in the new branch.

vipin.mittal18 → changed the visibility of the branch 3433859-automated-drupal-11 to hidden.

vipin.mittal18 → changed the visibility of the branch 3433859-automated-drupal-11 to active.

There is warnings

Warning: Undefined array key "character_length" in Drupal\password_policy_length\Plugin\PasswordConstraint\PasswordLength->validateConfigurationForm() (line 130 of /home/ide/project/docroot/modules/contrib/password_policy/password_policy_length/src/Plugin/PasswordConstraint/PasswordLength.php)

on saving "character length" password constraint but can be ignored for this ticket as restriction works perfectly.

Thanks for testing. If there are warnings, they should be fixed first please. Moving back to needs work.

Hello Kristen,

How are you doing?

Despite my best efforts, I was unable to reproduce the issue again, even after a fresh installation with Drupal 11.0.0-rc1. This issue appears not to exist, as my colleagues also tried to replicate it. Therefore, I believe we can release a Drupal 11 compatible stable version of password policy. Apologies for any disruption.

An animated GIF is created as a reference to indicate that there are no more warnings being logged

Thanks for retesting and providing more information. I probably won’t be able to look at this until next Tuesday or Wednesday. Feel free to ping me after that if I haven’t responded by Thursday next week.

+1 to get in and create new release

Thanks for the nudge… heads down on Starshot stuff for another couple days unfortunately. But maybe another maintainer has cycles. I’ll revisit later this week once I’m not under water.

Rajeshreeputra → changed the visibility of the branch 3433859-automated-drupal-11 to hidden.

Reviewed changes and looks good to me. However, looks like there are some un-related changes made to fix PHPCS & PHPStan etc. We can fix those in a separate ticket and limit the changes to Drupal 11 compatibility only.

Created MR!88 with the only required changes for Drupal 11 compatibility.

Reviewed and provided some suggestions.

Also tests are failing which needs to be fixed, see: https://git.drupalcode.org/issue/password_policy-3433859/-/jobs/2274918#L65

Address the changes.

Reverted the changes of PasswordResetBehaviorsTest files ~~ pipelines are passing.

Reviewed changes and looks good to me.
@vipin.mittal18 The warning you mentioned above was not due to changes made on this ticket and have been addressed separately as part of 🐛 [4.0.1 regression] password_length constraint should check plugin id in validateConfigurationForm() Fixed . Hence, merged.

Automatically closed - issue fixed for 2 weeks with no activity.