- Issue created by @jrglasgow
- Status changed to Needs review
4 months ago 7:57pm 23 July 2024 - π§πͺBelgium dieterholvoet Brussels
By switching to autowiring for the command class, you dropped support for any Drush version below 13. Drush 13 supports PHP versions 8.2 and above, so we would need to change the minimum PHP version here from 8.1 to 8.2 as well. I'm not sure that's worth it. I'll start a new MR with just the fix necessary for this specific issue, as recommended by the Drush maintainer in this PR.
- π§πͺBelgium dieterholvoet Brussels
Another option is to add back dependency injection in the original MR, so we can change the minimum Drush version to 11 and we don't need to increase the minimum PHP version. The refactors in that MR do seem valuable.
- First commit to issue fork.
-
berdir β
committed 6b44dda2 on 8.x-2.x authored by
dieterholvoet β
Issue #3463377 by dieterholvoet: Drush 13 compatibility
-
berdir β
committed 6b44dda2 on 8.x-2.x authored by
dieterholvoet β
- π¨πSwitzerland berdir Switzerland
Merged, please file a separate issue to remove the drush 8 integration, that's fine, but not willing to require drush 13 just yet.
The logger is only used in a single place and that is actually broken anyway, because it relies on global $user, which isn't a thing anymore. Issue to fix that welcome too.
- Status changed to Fixed
3 months ago 8:28pm 15 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.