Contrib.social

Automated Drupal 11 compatibility fixes for libraries

Open on Drupal.org →
Created on 18 March 2024, 8 months ago
Updated 13 September 2024, 2 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Project Update Bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 8 months ago
    27 pass
  • Comment 8 months ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-121090

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !21Automated Project Update Bot fixes → (Open) created by Project Update Bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 8 months ago
    27 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 8 months ago
    27 pass
  • Comment 8 months ago →
    Project Update Bot

    This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-137198

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.10
    3. palantirnet/drupal-rector: 0.20.1
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 8 months ago
    27 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 5 months ago
    27 pass
  • Comment 5 months ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-199781

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.3
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 5 months ago
    27 pass
  • First commit to issue fork.
  • Merge request !23#3431648 more Drupal 11 fixes → (Merged) created by jrglasgow
  • First commit to issue fork.
  • Pipeline finished with Failed
    3 months ago
    Total: 254s
    #259444
  • Pipeline finished with Failed
    3 months ago
    #259452
  • Pipeline finished with Failed
    3 months ago
    Total: 157s
    #259496
  • Pipeline finished with Failed
    3 months ago
    Total: 1234s
    #259498
  • Pipeline finished with Success
    3 months ago
    Total: 170s
    #259509
  • Pipeline finished with Success
    3 months ago
    Total: 160s
    #259515
  • Comment 3 months ago →
    🇮🇳India ankitv18

    ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

  • Comment 3 months ago →
    🇮🇳India ankitv18

    Please review MR!23

  • Status changed to RTBC 3 months ago
  • Comment 3 months ago →
    🇮🇳India vishalkhode

    Reviewed changes, looks good to me. Hence, RTBC.

  • Comment 3 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin

    warning: 1 line of the !23 merge adds whitespace errors.

  • Status changed to Needs work 3 months ago
  • Comment 3 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
  • Comment 3 months ago →
    🇮🇳India chandu7929 Pune

    Hello dqd → , Can you please provide some more details for the error or warning you are getting? May be there are steps to reproduce it?

  • Comment 3 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin

    There is nothing to "reproduce". It was a code review of mine to help. Trailing whitespace should be removed from patches and fork commits before getting committed/merged to the final branch, but it is up to the project maintainers to care of CoC and clean patches or not.

  • Status changed to Needs review 3 months ago
  • Comment 3 months ago →
    🇮🇳India ankitv18

    @dqd I believe you are requesting the changes related for phpcs issues.
    I guess we can cover that in https://www.drupal.org/project/libraries/issues/3257291 📌 Fix the issues reported by phpcs Needs review
    Also once issue is in RTBC until or unless changes are breaking something or get WSOD then moving back to needs work would help the community to work accordingly.
    Also If maintainer asked to make pipeline green in this issue only then I would push the related changes. Right now it consists the changes for Drupal 11.

    Thanks @chandu7929 trying to invest your time to take a look on this one ~~ moving back into review, hoping to get RTBC again.

  • Status changed to RTBC 3 months ago
  • Comment 3 months ago →
    🇮🇳India chandu7929 Pune

    Considering there's no issue in this MR, hence moving back to RTBC

  • Comment 3 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin

    @dqd I believe you are requesting the changes related for phpcs issues.

    Not sure what you mean. I request nothing. I made a code review and wanted to inform that the review turned out a whitespace warning. Not a big thing thou. I do not use this project nor do I maintain it. But enough other projects I do maintain over ages. It is simple and clear what my report was about. A very simple whitespace issue which (we know is a Drupal thing for reasons) would have been solved far qicker then the whole discussion here below. Again, it is up to the maintainers to decide and it is up to the community to try their best on code quality or not. This is how it used to be at least. It is a common care step to filter out these whitespaces on code reviews when these whitespaces have been added in the reviewed changes. And this is the place where to remove them again (hence "code review") At least in my 20 years of contribution. But I was quite surprised about the reaction here on such a simple review. Never mind. It is not my scope here. So have a wonderful weekend.

  • Comment 3 months ago →
    🇮🇳India ankitv18

    @dqd could you please comment out the whitespace issue in the file changes of current MR?

  • Comment 3 months ago →
    🇨🇦Canada joseph.olstad
  • Comment 3 months ago →
    System Message
  • Comment 3 months ago →
    🇨🇦Canada joseph.olstad
  • Status changed to Fixed 3 months ago
  • Comment 3 months ago →
    🇨🇦Canada joseph.olstad
  • Comment 2 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024