- Issue created by @carolpettirossi
- Merge request !143458639: Update dependencies to make sure more works with Drupal 10.3.x β (Open) created by carolpettirossi
- Status changed to Needs review
2 months ago 10:02pm 2 July 2024 - π¦π·Argentina tongadall
I just try this path and it solved the issues.
- π¦π·Argentina tongadall
Note for anyone who needs to know how to apply the patches, add these patches to composer.json:
"extra": { ... "patches": { "drupal/cl_editorial": { "#3456850: Support Drupal 10.3 SDC deprecation": "https://git.drupalcode.org/project/cl_editorial/-/merge_requests/12.patc" }, "drupal/sdc_display": { "#3458639: The module is not compatible with Drupal 10.3.0": "https://git.drupalcode.org/project/sdc_display/-/merge_requests/14.patch" } }, },
And execute:
composer update drupal/cl_editorial drupal/sdc_display
See the doc https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... β
I didn't even get that far. Tried installing, enabling and website encountered an issue.
[27-Jul-2024 12:59:18 America/Los_Angeles] Uncaught PHP Exception TypeError: "Drupal\cl_editorial\NoThemeComponentManager::__construct(): Argument #1 ($pluginManager) must be of type Drupal\sdc\ComponentPluginManager, Drupal\Core\Theme\ComponentPluginManager given, called in .../core/lib/Drupal/Component/DependencyInjection/Container.php on line 261" at .../modules/contrib/cl_editorial/src/NoThemeComponentManager.php line 23
- π¦π·Argentina tongadall
@digitaltodd About the issue that you mention in #6, have you appied the cl_editorial patch as I indicated in comment #5? This issue https://www.drupal.org/project/cl_editorial/issues/3456850 π Support Drupal 10.3 SDC deprecation RTBC
I tried too, but I do not thing it is working - getting applied.
My composer
"extra": { "patches": { "drupal/cl_editorial": { "#3456850: Support Drupal 10.3 SDC deprecation": "https://git.drupalcode.org/project/cl_editorial/-/merge_requests/12.patch" } }, ... other items }
> composer update drupal/cl_editorial
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Generating autoload filesvisit the site - unexpected error, php log shows same error. How can I tell if a patch has been applied?
I was missing that I needed to run [composer require cweagans/composer-patches]
Did that, patch applied, no more crash. Thanks
- π―π΄Jordan Rajab Natshah Jordan
Thank you, for MR14
Attached a static
sdc_display--2024-08-20--3458639--mr-14.patch
file.
To be used with Composer Patches - First commit to issue fork.
- πΊπΈUnited States Nuuou Lincoln, NE
Confirming that tests are failing due to π Support Drupal 10.3 SDC deprecation RTBC
- πΊπΈUnited States Nuuou Lincoln, NE
Attaching a new static patch file for folks that need it, similar to #11.