The module is not compatible with Drupal 10.3.0

I just try this path and it solved the issues.

Note for anyone who needs to know how to apply the patches, add these patches to composer.json:

    "extra": {
    ...
        "patches": {
            "drupal/cl_editorial": {
                "#3456850: Support Drupal 10.3 SDC deprecation": "https://git.drupalcode.org/project/cl_editorial/-/merge_requests/12.patc"
            },
            "drupal/sdc_display": {
                "#3458639: The module is not compatible with Drupal 10.3.0": "https://git.drupalcode.org/project/sdc_display/-/merge_requests/14.patch"
            }
        },
    },

And execute:

composer update drupal/cl_editorial drupal/sdc_display

See the doc https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

I didn't even get that far. Tried installing, enabling and website encountered an issue.

[27-Jul-2024 12:59:18 America/Los_Angeles] Uncaught PHP Exception TypeError: "Drupal\cl_editorial\NoThemeComponentManager::__construct(): Argument #1 ($pluginManager) must be of type Drupal\sdc\ComponentPluginManager, Drupal\Core\Theme\ComponentPluginManager given, called in .../core/lib/Drupal/Component/DependencyInjection/Container.php on line 261" at .../modules/contrib/cl_editorial/src/NoThemeComponentManager.php line 23

@digitaltodd About the issue that you mention in #6, have you appied the cl_editorial patch as I indicated in comment #5? This issue https://www.drupal.org/project/cl_editorial/issues/3456850 📌 Support Drupal 10.3 SDC deprecation RTBC

I tried too, but I do not thing it is working - getting applied.

My composer

 "extra": {  
        "patches": {
            "drupal/cl_editorial": {
                "#3456850: Support Drupal 10.3 SDC deprecation": "https://git.drupalcode.org/project/cl_editorial/-/merge_requests/12.patch"
            }
        },
... other items
}

> composer update drupal/cl_editorial
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Generating autoload files

visit the site - unexpected error, php log shows same error. How can I tell if a patch has been applied?

I was missing that I needed to run [composer require cweagans/composer-patches]

Did that, patch applied, no more crash. Thanks

Great!

Thank you, for MR14

Attached a static sdc_display--2024-08-20--3458639--mr-14.patch file.
To be used with Composer Patches

Confirming that tests are failing due to 📌 Support Drupal 10.3 SDC deprecation RTBC

Attaching a new static patch file for folks that need it, similar to #11.

Because core does this:

...
@class_alias('Drupal\Core\Template\ComponentNodeVisitor', 'Drupal\sdc\Twig\ComponentNodeVisitor');
@class_alias('Drupal\Core\Template\Loader\ComponentLoader', 'Drupal\sdc\Twig\TwigComponentLoader');
@class_alias('Drupal\Core\Theme\ComponentNegotiator', 'Drupal\sdc\ComponentNegotiator');
@class_alias('Drupal\Core\Theme\ComponentPluginManager', 'Drupal\sdc\ComponentPluginManager');
@class_alias('Drupal\Core\Theme\ExtensionType', 'Drupal\sdc\ExtensionType');
...

I think we could do this for a version 2.x compatible with Drupal 11.

Drupal 10 sdc module

https://git.drupalcode.org/project/drupal/-/blob/10.4.x/core/modules/sdc...

Drupal 11 sdc module (no module file)

https://git.drupalcode.org/project/drupal/-/tree/11.x/core/modules/sdc?r...

Pretty soon, all versions before 10.3 will be EOL and then 10.3 can be the minimum which removes the complexity of supporting multiple versions.