Create a failed login template.

Created on 25 August 2022, almost 2 years ago
Updated 19 June 2024, 9 days ago

Problem/Motivation

After #3198010: User login page broken when there are more than 5 failed login attempts for an account β†’ if a user fails login attempts, they are presented with the maintenance template. Although I agree with the idea of this lightware template for the purpose of Bot/Brute force, this is not very user-friendly if a maintenance page is themed separately or has messaging outside of config about site outages.

Steps to reproduce

- Fail 5 logins
- Get presented with maintenance twig template

Proposed resolution

- Provide a separate "failed_login" (or similar) template used for this scenario.

✨ Feature request
Status

Needs work

Version

11.0 πŸ”₯

Component
User systemΒ  β†’

Last updated about 20 hours ago

Created by

πŸ‡¨πŸ‡¦Canada b_sharpe

Live updates comments and jobs are added and updated live.
  • Needs change record

    A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¨πŸ‡¦Canada robbdavis

    Just had a client stumble upon this and the custom maintenance page and text made no sense in the context of failed login. They asked for a separate message / theme for failed login.

    A separate template option would be great.

    As a hack, I used a path-name class in the the body and hid the maintenance stuff and displayed blocked login stuff based on whether the path was `path-login`.

  • Status changed to Needs review 9 days ago
  • πŸ‡¨πŸ‡¦Canada b_sharpe

    Done. I did not create templates for themes like Claro/Olivero here as I believe those are opinionated and should be their own issues. I also didn't create tests here as no messaging has changed.

    What might be needed is a change record, as pages previously utilizing the maintenance page for this will now get a different template. Marking for review for now.

  • Pipeline finished with Failed
    9 days ago
    Total: 1489s
    #203044
  • πŸ‡¨πŸ‡¦Canada b_sharpe

    It appears there were tests around this already. Updated and added stable9 template as was expected as well.

  • Pipeline finished with Success
    9 days ago
    Total: 887s
    #203070
  • Status changed to Needs work 9 days ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Neat. Will definitely need a CR for the template addition.

  • Pipeline finished with Success
    about 13 hours ago
    Total: 512s
    #210154
Production build 0.69.0 2024