- Issue created by @carolpettirossi
- Merge request !313460078: Add field_heading_level to allow h1/h2 tag on banners. → (Merged) created by carolpettirossi
- Status changed to Needs review
6 months ago 11:31pm 8 July 2024 - 🇧🇷Brazil carolpettirossi Campinas - SP
I added the field, updated the templates, and kept the same styling for any choice of heading level by adding a block-title class.
Could someone please review it?
- Assigned to aleevas
- Issue was unassigned.
- 🇺🇦Ukraine aleevas
@carolpettirossi, Thank you for your code! It looks good, but I had to change the hook_update function to make importing the fields work well. Also, I bumped the changed libraries version.
The new field looking:
Ready for review - Status changed to Fixed
4 months ago 8:11pm 3 September 2024 - Status changed to Needs work
3 months ago 10:27pm 10 September 2024 - 🇺🇸United States froboy Chicago, IL
Couple issues raised from QA:
- the form is no longer using the Entity Browser
- Header level should only allow H1 or H2 - Merge request !33fix: [#3460078] Fix media widget and limit heading levels → (Merged) created by froboy
- Status changed to Needs review
3 months ago 10:58pm 10 September 2024 - Status changed to Fixed
3 months ago 6:48pm 13 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.