I appreciate the work here, and I'm contributing additional feature. I also found selective filter wasn't working with entity reference fields when using aggregation. When I use aggregation, the keys we have in the same place here are an array of keys. So I've tried to be the least intrusive and least duplicative as possible. I've kept the work in the original patch, but also included support for arrays of keys when aggregation is turned on and entity reference fields are aggregating with entity ID instead of target ID.
This is a reroll against 8.x-1.7, to give us an intermediary option. Agreed this should stay postponed and we should follow the core issue/solution.
mradcliffe → credited joshmiller → .
mradcliffe → credited joshmiller → .
mradcliffe → credited joshmiller → .
Setting to RTBC, per @Jaspreet-Kaur ... we continue to need and use this patch.
nicxvan → credited joshmiller → .
nicxvan → credited joshmiller → .
nicxvan → credited joshmiller → .
nicxvan → credited joshmiller → .
Sure! Perhaps I can update the tests, and make this a configurable option. I'll update in this thread if and when I start working. Until then, it's open for anyone else to do those things with the open merge request.
nicxvan → credited joshmiller → .
Chiming in here that this error, unnoticed by our team, took down urban.org briefly a few weeks ago when we updated to PHP 8.2.
Whatever the fix is, we're going to test out this patch, and we will need something to resolve this error.
How did this take down our elite Pantheon site? It eventually filled up our database with almost 500 GB of watchdog entries with thousands of warnings per record per user.
Commenting that I helped a mentored contribution table look into this issue. We were able to confirm the issue and we looked at the patches. Unfortunately this was happening later in the day and I think we all ran out of gas at the end. I'll review this in a few days if no one else from the group does and try to get it to RTBC so we might get some core credit for everyone's efforts.
I mentored!
joshmiller → created an issue.
joshmiller → created an issue.
joshmiller → created an issue.
joshmiller → created an issue.
I attended and triaged a number of issues.
joshmiller → created an issue.
joshmiller → created an issue.
I attended! :D
joshmiller → created an issue.
Adding attribution for my organization that sponsored my time :D
Hello! I'm working at the mentored contribution in Drupalcon Portland 2024. I will be working on this for the next few hours.
Updating issue summary.
RTBC++ ... Came here to point out this is an error state that happens when in Maintenance Mode, but I see that has already been covered.
For me, this fixes the error.
joshmiller → created an issue.
Confirming this is a problem the patch resolves the issue. Similar to 🐛 [2.0.x] $request->get may no longer return array as of Symfony 6.0 (BadRequestException) Fixed