QueryString::buildUrl causes error.

Created on 27 July 2023, 11 months ago

Updated 2 December 2023, 7 months ago

Problem/Motivation

I get this error, sorry no time to document how to reproduce.

Symfony\\Component\\HttpFoundation\\Exception\\BadRequestException: Input value \"page\" contains a non-scalar value. in /code/vendor/symfony/http-foundation/InputBag.php:37\nStack trace:\n#0 /code/web/modules/contrib/facets/src/Plugin/facets/url_processor/QueryString.php(92):

Steps to reproduce

JSON:API + Seach API + JSON:API Facets gives me this error on Drupal 10.1.1

Proposed resolution

One line change fixes it. I've seen this fix other modules in a similar fashion. Perhaps someone knows why this is needed?

From: $current_page = $get_params->get('page');

To: $current_page = $get_params->all('page');

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs review

Version

3.0

Component

Code

Created by

🇺🇸United States joshmiller Indianapolis, Indiana, USA

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @joshmiller
Status changed to Needs review 11 months ago7:48pm 27 July 2023
Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
Waiting for branch to pass
Comment 11 months ago →
🇺🇸United States joshmiller Indianapolis, Indiana, USA
For me, this fixes the error.
Comment 7 months ago →
🇧🇪Belgium StijnStroobants Leuven
Created patch for the 2.x-branch
Comment 7 months ago →
🇮🇳India Jaspreet-Kaur
reviewed! Patch #3 working on my end. Thanks!

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024