Convert '_none' option to a constant, deprecate form_select_options(), deprecate form_get_options() for removal, move form_select_options() to a new class.

Rebased against 11.x Branch.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased branch to 11.x, but getting some Functional tests failures

Tests pass

Title + MR title mention deprecating form_select_options but that doesn't appear to be the case.

You're right, I'll put it back with the trigger_error.
Shall I create a new CR for the deprecation or add it to the current draft?

Lets do a new one for the deprecation.

Current one could use some love but think adding a constant deserves to be separate.

OK. And one more question. Is core/tests/Drupal/KernelTests/Core/Form a good place to put the deprecation test?

Think that should be good since the function isn't in a module. Least I can't think of a better spot

Ughh the code removes form_get_options() too

Don't the new methods need tests for themselves?

dimitriskr → changed the visibility of the branch 11.x to hidden.

dimitriskr → changed the visibility of the branch 9.5.x to hidden.

Please ignore the change in .gitlab-ci.yml, which is for debugging purposes, all other changes and reported feedback are ready for this issue

Left some feedback.

Thanks @smustgrave.
Moreover in 📌 Deprecate form_get_options() Closed: duplicate it was proposed to remove form_get_options() as there is no usage in core and (then) in contrib. We need to see if we still want to do that here

In https://drupal.slack.com/archives/C1BMUQ9U6/p1707853736065729 , catch agreed to remove form_get_options() completely

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Still appears to have some open threads in the test. But rest is looking real good.

Keshav Patel → made their first commit to this issue’s fork.