- Issue created by @m.stenta
- 🇺🇸United States m.stenta
One place where this is currently used in contrib is in the Simple OAuth (OAuth2) → module.
https://git.drupalcode.org/project/simple_oauth/-/blob/72d1960624a9b05ac...
This is used to check if an OAuth2 scope, which is tied to a Drupal role, has a given permission.
- 🇮🇳India samit.310@gmail.com
samit.310@gmail.com → made their first commit to this issue’s fork.
- Merge request !96323476166: Deprecate RoleStorage::isPermissionInRoles() → (Open) created by samit.310@gmail.com
- 🇮🇳India samit.310@gmail.com
Hi @m.stenta,
I have created the MR and Change records → page as well. Please review.
Thanks
Samit K. - 🇫🇷France andypost
Added comment, docs about deprecation process https://www.drupal.org/about/core/policies/core-change-policies/how-to-d... →
- 🇮🇳India samit.310@gmail.com
Thanks @andypost,
I am working as you suggested.
Thanks
Samit K. - 🇮🇳India samit.310@gmail.com
Hello @andypost,
Changes applied as per your suggestion, Please review.
Please also review https://www.drupal.org/node/3477235 →Thanks
Samit K. - 🇬🇧United Kingdom longwave UK
This hasn't actually deprecated the RoleStorage class, only the method. I think we should stop using the class entirely here and deprecate both RoleStorage and RoleStorageInterface.
- Status changed to Needs work
about 2 months ago 3:06pm 10 December 2024 - First commit to issue fork.
- Merge request !10506Draft: Resolve #3476166 "Deprecate rolestorage" → (Closed) created by dimitriskr
- 🇬🇷Greece dimitriskr
dimitriskr → changed the visibility of the branch 3476166-deprecate-rolestorage to hidden.
- 🇬🇧United Kingdom joachim
> I think we should stop using the class entirely here
How does that work though?
RoleStorageInterface is covered by BC, so that means if you ask for the storage handler for the role entity, should should expect to get that interface. So we can't remove the class at this point, it has to stay until RoleStorageInterface is removed in 12.0.
