- First commit to issue fork.
- Merge request !5840Resolve #2002012. Inject the display plugin manager into the view and view factory β (Open) created by dimitriskr
- Status changed to Needs review
over 1 year ago 12:02pm 17 December 2023 - Status changed to Needs work
over 1 year ago 7:41pm 19 December 2023 - πΊπΈUnited States smustgrave
Issue summary should be updated to the standard issue template.
Left some feedback but new parameters can probably be typehinted and new parameters probably have to do the backwards compatibility thing.
- Status changed to Needs review
over 1 year ago 5:00pm 21 December 2023 - πΊπΈUnited States smustgrave
smustgrave β changed the visibility of the branch 2002012-inject-the-display to hidden.
- πΊπΈUnited States smustgrave
smustgrave β changed the visibility of the branch 11.x to hidden.
- Status changed to Needs work
over 1 year ago 7:09pm 21 December 2023 - πΊπΈUnited States smustgrave
Great job! Think only thing missing is an a test for the deprecation.
Will keep an eye out for this to come back.
- Status changed to Needs review
over 1 year ago 9:04pm 6 January 2024 - Status changed to RTBC
over 1 year ago 5:32pm 7 January 2024 - Status changed to Needs work
about 1 year ago 6:51am 5 February 2024 - π³πΏNew Zealand quietone
Lovely to see an old issue nearly completed!
I'm triaging RTBC issues β . I read the IS and the comments. I didn't find any unanswered questions.
I read the MR and made suggestions in the MR so setting to NW for that.
I read the change record and made some changes to the text. However, the branch and version number are incorrect. I am tagging for CR update. The introduced in branch is not 11.x it will be 10.3.x.
- Status changed to Needs review
about 1 year ago 10:18pm 13 February 2024 - Status changed to RTBC
about 1 year ago 11:10pm 13 February 2024 - Status changed to Needs work
about 1 year ago 12:04pm 4 March 2024 - Status changed to Needs review
about 1 year ago 7:43pm 4 March 2024 - Status changed to RTBC
about 1 year ago 10:14pm 4 March 2024 - πΊπΈUnited States smustgrave
Appears feedback from @catch has been addressed.
- Status changed to Fixed
about 1 year ago 6:24pm 16 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 23bb407de3 to 11.x and 7f5ab91043 to 10.3.x. Thanks!
I think we could open a follow-up to use the DependencySerializationTrait in ViewsExecutabl... it'll be a little complex because we'll need to do a little work to make things work...
Also I think we should open a follow-up to use $this->provider in \Drupal\views\ViewExecutable::hasUrl() instead of \Drupal::service(). -
alexpott β
committed 7f5ab910 on 10.3.x
Issue #2002012 by dimitriskr, dawehner, smustgrave, quietone,...
-
alexpott β
committed 7f5ab910 on 10.3.x
-
alexpott β
committed 23bb407d on 11.x
Issue #2002012 by dimitriskr, dawehner, smustgrave, quietone,...
-
alexpott β
committed 23bb407d on 11.x
- πΊπΈUnited States smustgrave
Not sure if either of them should be tagged novice though?
Automatically closed - issue fixed for 2 weeks with no activity.