Specify PDF save directory name, create it on install

We will adapt this patch for 3.x

Hi,

I have rerolled patch #3 for version 3.x-dev branch, please review it.

Thanks & Regards,
Mrinalini

Thank you very much! I will generate a MR from this code.

Suggestions:

- In #2735259 ✨ Saving to Server in alternate location Closed: duplicate the schema could be choosen - I like this idea. Will we adapt this?

- In 3.x branch we create the dir on the fly - I think we can drop the creating while installing.

We implemented your patch and added some tests.

Please review and feedback.

looks good!
Please make sure that the ‘pdf_save_path’ configuration value is validated. For example '../documents' causes a DirectoryNotReadyException in $this->fileRepository->writeData
This can be avoided by validating the access/existance and making sure that if $this->fileSystem->prepareDirectory returns false, all subsequent operations are canceled.

Thank you for feedback!

Please review.

looks all right.
I would prefer if it wasn't stored unvalidated, but I understand that the current architecture doesn't support that. Maybe in the future we can generate/validate this directory when submitting the configuration form. Then it will be similar to how file paths are handled.

Thank you all for 5 years from idea to merge!

I merged this issue to 3.x.

Automatically closed - issue fixed for 2 weeks with no activity.