- Issue created by @jan kellermann
- 🇩🇪Germany jan kellermann
I diffed both versions:
3166c3166 < const a = e.getConsent(s.name) && e.confirmed --- > const a = e.getConsent(s.name) && (e.confirmed || s.optOut)
This is the expected change, so the new version should be correct.
- 🇩🇪Germany jurgenhaas Gottmadingen
This is hard to review. Is it intentional that they switched to pre-processed assets? If this is what it is, then we can only test this on an installed version to check if everything still works, right?
And the change is coming from a PR that hasn't been commented by the upstream maintainers nor has it been merged or released. Before we start introducing changes here ourselves, we need a policy on how to maintain this library. It will be a mess, if we decouple the code here from the one upstream.
- Status changed to Needs review
2 months ago 11:12am 19 June 2025 - 🇩🇪Germany jan kellermann
The PR is committed to upstream. I would like to release our next version of klaro-js.
Here you can see the differences between our master and their master: https://github.com/kiprotect/klaro/compare/master...werk21:klaro-js:master
- reduce browserlist to "default" (size of JS!)
- minor updates to npm for build tool stack (dependabot security updates)
- fix hu-translation (missing "" with string with ":")You can see here all the differences between last 7.22 version and our current master:
https://github.com/kiprotect/klaro/compare/v0.7.22...werk21:klaro-js:master- fix: csp violation for style attributes
- feat: add support for nonce attribute
- Fixed an issue with Klaro autofocus
- Check for optOut state while contextual rendering - 🇩🇪Germany jan kellermann
I suggest tagging this as 3.1.0. Then the Klaro 3.0.x versions should not pull it (constraint: `drupal/klaro_js: ~3.0.0`).
We are planning the 3.1.x Klaro version with some new features, so we have time to test it.