- Issue created by @aleix
- 🇪🇸Spain aleix
with this patch if item title is '-' and url is it will be converted to hr
- 🇪🇸Spain aleix
(patch will not apply, must be placed in /components/dropdown-menu/ ... sorry)
Thanks a lot Aleix for the patch and the issue.
I am yet to test this but I wonder if this is a proper solution fornolink
andbutton
, they will probably fall into theelse
section.the
-
for the divider works I suspect but not sureThat aside, if they are meant to be a dropdown, does it need a
dropdown-header
class maybe?- 🇪🇸Spain aleix
(upgraded issue description to show tags, without this is impossible to understand what I was saying... 🙏🏻)
- 🇪🇸Spain aleix
That aside, if they are meant to be a dropdown, does it need a dropdown-header class maybe?
Sure, menu items to be headers must be preprocessed or in ui with https://www.drupal.org/project/menu_link_attributes → to add dropdown-header
- 🇪🇸Spain aleix
I see, thanks Aleix, could you also do me a favor and update the README file of the component as well if needed in the MR?
- 🇪🇸Spain aleix
Yes, so ¿ Do you mean adding there the notes about the use of
<nolink>
together with "-" and<button>
? - 🇪🇸Spain aleix
Done, maybe someday the button logic can be extended to be more accessible from dropdown component properties, maybe when someone needs it can be changed. Thank's doxigo