Allow using <nolink> and <button> in menu items

with this patch if item title is '-' and url is it will be converted to hr

(patch will not apply, must be placed in /components/dropdown-menu/ ... sorry)

Uploading working patch

Thanks a lot Aleix for the patch and the issue.
I am yet to test this but I wonder if this is a proper solution for nolink and button, they will probably fall into the else section.

the - for the divider works I suspect but not sure

That aside, if they are meant to be a dropdown, does it need a dropdown-header class maybe?

(upgraded issue description to show tags, without this is impossible to understand what I was saying... 🙏🏻)

That aside, if they are meant to be a dropdown, does it need a dropdown-header class maybe?

Sure, menu items to be headers must be preprocessed or in ui with https://www.drupal.org/project/menu_link_attributes → to add dropdown-header

I think that there's no problem in falling to the else as link supports bothnolink and button urls so the only special cases are <nolink> with title == -, and now button as I have updated the MR, covering the way how button can be rendered using our component.

I see, thanks Aleix, could you also do me a favor and update the README file of the component as well if needed in the MR?

Yes, so ¿ Do you mean adding there the notes about the use of <nolink> together with "-" and <button> ?

Yes that, so I can merge and call it a day :D

Done, maybe someday the button logic can be extended to be more accessible from dropdown component properties, maybe when someone needs it can be changed. Thank's doxigo

Yeah sounds good, we should look into that at some point, Thanks a lot for the MR 🙌

Automatically closed - issue fixed for 2 weeks with no activity.