5.2.x -> 6.0.0 upgrade error

Could you please check on which line the id() is giving null?

I think i tracked it down to line 297 of simple_oauth.install and $role is NULL.
Line 299 then errors with the $role->id() call.

I think this is resulting of the default_consumer that is created with the installation which we never used or removed. This is not assigned any scope and therefore has no roles.

See the screenshot. Unsure if we should catch this case in the update function of close the issue because of the bogus setup I have.

mhm If i remove the bogus client(s) I get the following error message:

>  [error]  SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '2-0-0-de' for key 'PRIMARY': INSERT INTO "consumer__scopes" ("bundle", "deleted", "entity_id", "revision_id", "langcode", "delta", "scopes_scope_id") VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6); Array
> (
>     [:db_insert_placeholder_0] => consumer
>     [:db_insert_placeholder_1] => 0
>     [:db_insert_placeholder_2] => 2
>     [:db_insert_placeholder_3] => 2
>     [:db_insert_placeholder_4] => de
>     [:db_insert_placeholder_5] => 0
>     [:db_insert_placeholder_6] => content_editor
> )
>  
>  [error]  Update failed: simple_oauth_update_8604 
 [error]  Update aborted by: simple_oauth_update_8604 
 [error]  Finished performing updates. 

I think we should add some extra checks in that hook:

• If role is not NULL.
• If scope already exists.
• If scopes are already referenced on the associated consumer.

This way we can rerun the hook_update.

@yobottehg could you please check if the fix in MR 177 resolves the issue?

The upgrade function works now.

However this creates now dynamic scopes which did not exist before or were not used before.
Also on these dynamic scopes the assigned role is missing.

On screenshot 1 with the author roles only the nest.js_site and the webform_client did exist and were used before. The other 2 dynamic scopes are used user roles but only for backend authors.

On screenshot 2 the missing role on the dynamic scope is visible.

I find it not clear how to reproduce your issue, so it's hard for me to figure this one out. The hook_update: simple_oauth_update_8604 tries to migrate existing (old) scope settings from your consumers to the new dynamic scopes, so if this didn't work you could always just manually configure your dynamic scopes and consumers.

You are right. The first mentioned problems are solved and the update function is working now.

I just wanted to point out that the whole update procesdure from 5.2.x -> 6.0.0 is rather confusing and not an "unattanded process". The complete config needs to be reviewed and updated / deleted before it can be deployed as otherwise the oauth config does not work (at least for me)

This causes the error mentioned above and I kinda don't see any way around recovering this

When applying this patch, I now get the same issue fixed in 🐛 Mismatched entity and/or field definitions Error when upgrading from 5.2.5 to 6.x Active .
Some issue within the update hook maybe?

Perhaps we should remove the simple_oauth_update_8604, like I said before it's a migration from old scopes (roles) to the new scope entity, which perhaps doesn't cover all different cases. A manual migration/configuration is the safest way to upgrade from 5.2 to 6.0.