Radix and Vartheme

Created on 11 September 2023, 10 months ago
Updated 24 April 2024, 2 months ago

Hey there guys πŸ‘‹

Vartheme seems to be an enhanced version of Radix with a lot of fixes/improvements, great job there

Now that I'm working on releasing 5.1.x of Radix and making it SDC compatible, I see that you've already done that, I guess at some point we should've collaborated together instead of copy/pasting into different projects (I'll borrow some of your SDC implementations, thanks in advance)

Even though some directions seem different we will have a lot in common and you guys have already done a lot of work

My suggestion is that we should merge what you've done into Radix and you guys become the maintainer of the theme as well, considering I am not as free as I'd like to be to be able to properly maintain the theme alone, I'd be happy if you guys would join.

I am not sure how the branding would work in Vardot world and if this is okay to do so or not

let me know what you think

🌱 Plan
Status

Closed: won't fix

Version

3.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @doxigo
  • πŸ‡―πŸ‡΄Jordan Rajab Natshah Jordan

    Thank you, Sohail, for working on Radix.

    • Started Vartheme BS5 based on Radix components + selected templates from Barrio.
    • Doing more expermentaitons with SDC, an no Bootstrap theme was doing SDC with Bootstrap 5 yet
    • Converted some of your old componentsWIP to SDC components.
    • Looking at Radix ~6 ( Tempaltes, and components) - Thank you, learning
    • Looking at Bootstrap Barrio ( Templates ) - Thank you to all Maintainers

    Hppay that you find anything helpfull from our code and logic :).
    Borrowing some from your latest work for sure, and the logic.

    We will keep looking at the code and learning from.
    Maybe when we jump to Bootstrap 6 and if your theme was ready first, It may be used as the default base theme.

  • Status changed to Closed: won't fix 2 months ago
  • Let's hope that I manage to get the Radix to a RC state first, it has been one too many fixes/commits.

    but yeah let's evaluate at a more stable state later on, thanks a lot for your work as well, closing the ticket then.

  • πŸ‡―πŸ‡΄Jordan Rajab Natshah Jordan

    Thanks, Sohail, for passing by

    You can notice that our Varbase Accordion component started from your old WIP
    and advanced to our custom Varbase Design System

    Maybe changed the logic and needed to create an Accordion Item component to be used with the Accordion main component

    By the way
    πŸ“Œ Add a new Accordion Item and Accordion components with stories for storybook following with Varbase Design System Active
    πŸ“Œ Change the style of Accordion and Accordion Items to follow with Varbase Design System Active
    πŸ“Œ Add Varbase Accordion Block module in accordance with the Varbase Design System standards Fixed

    Storybook doc page for Accordion

    Studing doing the Tabs too. It is good to have a starting point for Bootstrap 5.
    or at least to see how other type of components are built and how they are used with Drupal templates.

  • A lot of great work there with examples and Storybook integration, I hopefully will get there soon if I find some free time, still not sure about integrating with the " Storybook β†’ " module or the old approach.

    Will have to investigate a bit further.

    Regarding the Accordion (and similar child/parent components), I wasn't sure if a separate component makes sense or not. I just went on with 1 component fits all approach.

Production build 0.69.0 2024