Bootstrap 5 removed form-inline class

Hey James, Thanks for a nice find, please provide the MR, I appreciate it, thanks

So, I think that merge request is the way to do it.

It assumes that the bootstrap classes I've added in place of form-inline are the correct ones. I'd be glad for someone to check that. (It works on the site I'm testing on, at all browser widths, but I'm not 100% sure this is the canonical Bootstrap way to do this).

Doing it in the Form component means that any templates that call radix:form with is_inline:true will pick up the new markup without having to change every templates. So I think is the DRY way to fix this.

Thanks James, I'm not sure if flex-row and flex-wrap are needed, are they? can you test without? if so update the MR?

Also just triggered an error on another pageload, so I'm just investigating that.

OK

My twig bug was because of a hastily (and embarrassingly) mistyped ternary operator. Oops.

I can confirm that you don't need flex-row, because that's the default

It seems that you don't need flex-wrap either, but I'm testing on the search form which is pretty small. The default is flex-nowrap, and I'm not clear what happens if it's a bigger inline form. I can put flex-wrap back if that's desirable, but for the time-being the latest iteration of the MR works fine for me.

Perfect work James, merged

Eh, this is a breaking change. I use form-inline for a number of custom styles. I don't think we can just remove that class without breaking sites.

Suggest we add to form-inline, rather than replace it. @doxigo: thoughts?

jamesoakley → closed merge request !133

I'd be inclined to agree.

form-inline won't get picked up by Bootstrap to do anything.

But you're quite right - that doesn't mean people won't be picking up on the class to do their own CSS.

Having got into a tangle with how Gitlab's merge requests work when you making further changes to the same issue fork, I think the latest MR is now what's needed. Tested and it still works, but also leaves form-inline in place.

Hey Dan, you are correct, I missed the breaking change part, it definitely is. We should ideally keep it and also add the new d-flex class.

Thanks for the updated MR James