- Issue created by @cYu
- Merge request !139Issue #3526166 by cYu: Update documented prop definition to match component β (Merged) created by Unnamed author
- First commit to issue fork.
-
doxigo β
committed bdfaf5c2 on 6.0.x authored by
cyu β
Issue #3526166: Update property definition for backdrop in offcanvas...
-
doxigo β
committed bdfaf5c2 on 6.0.x authored by
cyu β
Thanks a lot Christopher, merged and updated the https://radix.trydrupal.com/radix/components/offcanvas as well
I noticed some duplicates there as well, that aside I wonder if we should make that into a boolean instead of string.
Would appreciate another MR- πΊπΈUnited States cYu
Yeah, a value of "static" shouldn't be doing anything there, based on https://getbootstrap.com/docs/5.0/components/offcanvas/#options, so switching to boolean looks like the right move.
https://getbootstrap.com/docs/5.0/components/modal/#options accepts "static" plus boolean values, but that Radix modal component looks like it only supports setting to "static" or not setting a data-bs-backdrop value (defaulting to true), with no way to set data-bs-backdrop="false"
Automatically closed - issue fixed for 2 weeks with no activity.