- Issue created by @ptmkenny
- 🇳🇱Netherlands megachriz
Alright, good idea. I think that we can only test this by writing a custom Tamper plugin? Maybe it would be good to have a Tamper plugin using attributes in a test module, so that we can add test coverage for this addition?
- 🇯🇵Japan ptmkenny
Thanks for the super quick response. As for testing this, I just converted all the annotations to attributes in 📌 Add attributes alongside annotations Postponed . That can't be committed until this module requires Drupal > 10.2, but it does give test coverage of the attribute class (since all the tests will be run there with attributes instead of annotations), but then of course the test is in a separate issue instead of in this one, where the class will initially be committed.
- 🇯🇵Japan ptmkenny
Tests in 📌 Add attributes alongside annotations Postponed are failing; those should be fixed before this is committed.
- 🇳🇱Netherlands megachriz
I'm not sure if I want to require Drupal 10.2 yet, so because of that it might be useful to add test coverage for this.
- 🇯🇵Japan ptmkenny
As you referenced in the other issue, TamperManager needs to be updated to match this change record: https://www.drupal.org/node/3395582 →
I'll try to get to this tomorrow. I'll fix this issue and the other one first, and then see about adding a test just for this one.
- 🇯🇵Japan ptmkenny
Hmm, adding this change breaks Drupal 9, so perhaps this issue should be closed in favor of 📌 Add attributes alongside annotations Postponed , which then that issue can be committed someday when support for older versions of Drupal are dropped?
- Status changed to Needs review
3 months ago 1:07am 8 January 2025 - 🇯🇵Japan ptmkenny
Closed in favor of 📌 Add attributes alongside annotations Postponed