- last update
almost 2 years ago 1 pass - 🇳🇱Netherlands maurice@atom
I've made some alterations so the key is included, and used `use-credentials` for the crossorigin
- First commit to issue fork.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Hi All! Do you think adding this
<link rel="preconnect" href="https://www.googletagmanager.com"/>HTML element is necessary or beneficial to the 2.x version of this module as well? Here's a straightforward patch for 2.0.8 based on the previous patches.
This patch sets crossorigin to its default; NOT to use-credentials as this seems to be only required for very specific cases. Maybe a more complete version allows controlling this for each tag from the admin interface?
- 🇯🇵Japan ptmkenny
Since the module has GitLab CI tests now, we need an MR, not a patch, because the CI tests are only run for MRs, not patches.
- 🇺🇸United States luke.leber Pennsylvania
I'm not sure that a preconnect would help with LCP at all given the module loads the script async. Loading async removes the JS from the critical render path.
The best thing that the Google Tag module can do to help with improving LCP is to inline the first party JS (or add the async or defer attribute) to it.
Preconnecting to the third party that's already loading async won't help anything unless the LCP element is being loaded from tag manager -- which would be an even bigger problem 😅.