- Issue created by @ro-no-lo
- 🇩🇪Germany ro-no-lo
I'll provide a fix for the 1.x branch, which will introduce a ignore list. I just have to figure out the git stuff, as always.
- Merge request !11Issue #3335627 by Shubham Rathore: Update core_version_requirement on info.yml... → (Merged) created by ro-no-lo
- 🇧🇪Belgium vodde83
It is somewhat unclear to me, how the ignore list actually functions.
There is some documentation provided, but the mentioning of 'jsonapi' first got me confused as I use the JSON:API Extras module, and I changed my JSON:API path prefix to 'api'. But maybe that's just me :DNow, I'm not sure if it actually works, as I tried a variety of combinations in the "Do not touch" section, but all my links still end up being removed. I'm basically trying to do the same thing as the reporter, make sure the image derivatives links are kept.
I delved a bit into the code to try and figure it out, but I keep getting either an empty string or integers in
$path
after this code:$path = implode('.', $this->path);
(the first line inisOnIgnoreList()
).
And if$path
contains simply an empty string or an integer, I'm not seeing how that could ever pass thepreg_match
. - 🇯🇵Japan ptmkenny
@vodde83 If you change the path in a module like JSON:API Extras, you have to take responsibility yourself for modifying the path; this module doesn't have a way to determine what overrides you may have made.
Hopefully @ro-no-lo, as the author of the code, can describe how it is supposed to work.