Extra h2 block title in Facet Block template

Created on 21 December 2023, 11 months ago
Updated 21 January 2024, 10 months ago

Problem/Motivation

Axe A11y Tools picks up an empty H2 in the Facet block template, seen on the sector search page.

https://git.drupalcode.org/project/sector_theme/-/blob/1.1.x/themes/sect...

Steps to reproduce

Go to a Sector instance dev page and search for "Sector". On the left, in the sidebar below the Facet results, in the DevTools code, you'll see an empty

<h2 data-component-id="sector_theme:block-title"></h2>

Proposed resolution

Initiallly I thought to remove the extra item in the template
{% include 'sector_demo:block-title' with { } only %}
but we need this to include the library, so rather made the block title only render if there is a label.

🐛 Bug report
Status

Fixed

Version

1.1

Component

Code

Created by

🇳🇿New Zealand stewest Wellington

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024