🇺🇦Ukraine @Lysenko

lysenko → made their first commit to this issue’s fork.

Hello,
I do not think that this is a bug as such, the described behavior corresponds to the behavior of the core

For example, if you create a field of the Text (plain) type and make it multiple, then when creating a node, you will see 2 empty fields of this type.

The behavior of the default value also corresponds to the behavior from the kernel, the default value is not copied when creating an item on the node editor

Therefore, I think this issue can be closed or marked as Fetrue request

Tested on drupal 10.1
PHP: 8.1.27
version: 8.2.4
The patch: https://git.drupalcode.org/project/tablefield/-/merge_requests/30.diff from this issue: https://www.drupal.org/project/tablefield/issues/3321023 🐛 Error when deleting a tablefield RTBC resolved issue for me

lysenko → made their first commit to this issue’s fork.

lysenko → changed the visibility of the branch 3076448-wysiwyg-support-on to active.

lysenko → changed the visibility of the branch 3076448- to active.

lysenko → changed the visibility of the branch 3076448-wysiwyg-support-on to hidden.

After reviewing the patch, I think that this issue can be closed because the patch contains changes using the object context for static functions, I also reviewed the t()/$this->t() calls in other files and made sure that the translation function was applied correctly to other calls

1) Fixed issue with rendering cells that have only spacers as content
2) Added Unit tests in order to cover functionlaity of the new settings: 'hide_empty_rows', 'hide_empty_columns'

Hello @stewest,
Did you enable setting "Don't display empty rows" in the field`s formatter?

dinazaur → credited Lysenko → .

dinazaur → credited Lysenko → .

Denis Waßmann,
This problem is caused by the fact that empty cells are stored in the field value.

This merge request adds settings to the field`s formatter that allows to hide empty row or columns, I didn't change the status of the task in "Needs review" because I haven't finished adding tests for the new functionality, but the functionality itself is already working

I would be grateful if you try to install this patch on your website and give me feedback

+1 RTBC
Works and looks fine

Lysenko → made their first commit to this issue’s fork.

+

+1 RTBC

+1 RTBC

+ 1 RTBC

Lysenko → created an issue.

+1 RTBC

+1 RTBC

Lysenko → made their first commit to this issue’s fork.

+1 RTBC

The issue with empty cells arises because of this pull request: https://git.drupalcode.org/project/tablefield/-/commit/26d63be6aa25d34d1...

The spacer and the #weight are rendered as empty cells

My path of the module update.
The main issues arise from trying to update a module by jumping multiple versions.

Before running of the update need to see if was performed this hook
It includes code that makes the object ID unique, allowing you to perform the following updates for version 4.0.0-alpha1

You may also have a problem with the same timestamp under multiple documents.
The solution to this issue is described in this comment 🐛 Cannot update. Getting Mysql error Active Thanks man!

You may also have a question that is described here 🐛 Length of menu_tree.url and menu_tree.route_param_key are too short (255 characters) Needs review .
It occurs due to the use of a timestamp in the entity identifier.

The reason for the original question of this issue is described here
The easiest solution to this problem is to use a database dump that was made before running the update.

I did move the changes from the patch #2 into merge request also did add the fix for the error: "Cannot call methods on autocomplete prior to initialization; attempted to call method 'destroy'"

After applying patch #3, almost everything works fine, but I get a minor error

Error: cannot call methods on autocomplete prior to initialization; attempted to call method 'destroy'

It is caused by this line:
$(context).find("input.form-autocomplete").autocomplete("destroy");

I prepared a small distortion

        var autocompleteForm = $(context).find("input.form-autocomplete");
        if (autocompleteForm.hasClass('ui-autocomplete')) {
          autocompleteForm.autocomplete("destroy");
        }

Lysenko → made their first commit to this issue’s fork.

I have the same error

> [notice] Update started: entity_legal_update_9002
> [error] SQLSTATE[42000]: Syntax error or access violation: 1075 Incorrect table definition; there can be only one auto column and it must be defined as a key: ALTER TABLE "entity_legal_document_version" DROP PRIMARY KEY; Array

Lysenko → created an issue.

In my opinion, this question arose because of a change in this place:
public string $operator;

The value NULL for this variable is assigned here if the passed string does not match the regular expression

The simplest solution seems to be to allow the variable $operator to be NULL

Lysenko → made their first commit to this issue’s fork.

Lysenko → created an issue.

https://www.drupal.org/node/3238136 →

https://www.drupal.org/node/3238136 →

Lysenko → created an issue.

Lysenko → created an issue.