- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 4:21pm 23 May 2023 - 🇮🇳India keshavv India
keshav.k → made their first commit to this issue’s fork.
- @keshavk opened merge request.
- Status changed to RTBC
about 2 years ago 9:24am 24 May 2023 - 🇮🇳India keshavv India
Reviewed and tested patch.
It is working good. Created MR for easy merge -
zterry95 →
committed df9c2539 on 8.x-1.x authored by
keshav.k →
Issue #3362224: PHP Fatal Error | Drupal\Core\Entity\Query\...
-
zterry95 →
committed df9c2539 on 8.x-1.x authored by
keshav.k →
- Status changed to Fixed
almost 2 years ago 3:01pm 7 September 2023 - 🇸🇮Slovenia deaom
The MR seems to be merged, but the status was not changed to fixed, so just updating the status.
- Status changed to RTBC
almost 2 years ago 3:04pm 7 September 2023 - 🇸🇮Slovenia deaom
Changing the status back to RTBC, so maintainers can give credit.
jp_sc → changed the visibility of the branch 3362224-php-fatal-error to hidden.
jp_sc → changed the visibility of the branch 3362224-php-fatal-error to active.
Same issue seems to appear in recently_read_cron() in recently_read.module.
- 🇬🇧United Kingdom j_edery
I have found another Drupal 10 compatibility issue with the code which results in a PHP error during testing.
- Merge request !18Issue #3362224: PHP Fatal Error | Drupal\Core\Entity\Query\QueryException:... → (Merged) created by j_edery
- 🇬🇧United Kingdom j_edery
I have issued another merge request to resolve the issue. I have tested and can confirm this resolves the PHP fatal error when running cron.
- 🇬🇧United Kingdom j_edery
I have added my fix to a new issue and created a merge request here: https://www.drupal.org/project/recently_read/issues/3407065#comment-1535... 🐛 PHP Fatal Error | Cron execution Entity queries must explicitly set whether the query should be access checked or not Needs review
- First commit to issue fork.
- 🇫🇷France loicfer
Hello,
When using this module on Drupal 10, it throws a QueryException because entity queries in both recently_read.module and RecentlyReadService.php do not explicitly define whether to check for access permissions.
This patch adds ->accessCheck(TRUE) to all affected entity queries:
- recently_read_cron() in recently_read.module
- getRecords() method in RecentlyReadService.php
This is required since Drupal 9.4+, and mandatory in Drupal 10.
This patch takes up the old patch and adds the fix to it for the getRecords() method✅ The patch is tested and works with Composer patching.
Thanks for maintaining the module!
Best regards,
- First commit to issue fork.
-
jernejmramor →
committed 323084da on 8.x-1.x authored by
j_edery →
Issue #3362224: PHP Fatal Error | Drupal\Core\Entity\Query\...
-
jernejmramor →
committed 323084da on 8.x-1.x authored by
j_edery →
- 🇸🇮Slovenia jernejmramor
Closing this as this was tested, merged and resolved. Credited everyone that spent time on this. This will be included in the next release of this module.