- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 4:21pm 23 May 2023 - ๐ฎ๐ณIndia keshavv India
keshav.k โ made their first commit to this issueโs fork.
- @keshavk opened merge request.
- Status changed to RTBC
almost 2 years ago 9:24am 24 May 2023 - ๐ฎ๐ณIndia keshavv India
Reviewed and tested patch.
It is working good. Created MR for easy merge -
zterry95 โ
committed df9c2539 on 8.x-1.x authored by
keshav.k โ
Issue #3362224: PHP Fatal Error | Drupal\Core\Entity\Query\...
-
zterry95 โ
committed df9c2539 on 8.x-1.x authored by
keshav.k โ
- Status changed to Fixed
over 1 year ago 3:01pm 7 September 2023 - ๐ธ๐ฎSlovenia deaom
The MR seems to be merged, but the status was not changed to fixed, so just updating the status.
- Status changed to RTBC
over 1 year ago 3:04pm 7 September 2023 - ๐ธ๐ฎSlovenia deaom
Changing the status back to RTBC, so maintainers can give credit.
jp_sc โ changed the visibility of the branch 3362224-php-fatal-error to hidden.
jp_sc โ changed the visibility of the branch 3362224-php-fatal-error to active.
Same issue seems to appear in recently_read_cron() in recently_read.module.
- ๐ฌ๐งUnited Kingdom j_edery
I have found another Drupal 10 compatibility issue with the code which results in a PHP error during testing.
- Merge request !18Issue #3362224: PHP Fatal Error | Drupal\Core\Entity\Query\QueryException:... โ (Open) created by j_edery
- ๐ฌ๐งUnited Kingdom j_edery
I have issued another merge request to resolve the issue. I have tested and can confirm this resolves the PHP fatal error when running cron.
- ๐ฌ๐งUnited Kingdom j_edery
I have added my fix to a new issue and created a merge request here: https://www.drupal.org/project/recently_read/issues/3407065#comment-1535... ๐ PHP Fatal Error | Cron execution Entity queries must explicitly set whether the query should be access checked or not Needs review
- First commit to issue fork.
- ๐ซ๐ทFrance loicfer
Hello,
When using this module on Drupal 10, it throws a QueryException because entity queries in both recently_read.module and RecentlyReadService.php do not explicitly define whether to check for access permissions.
This patch adds ->accessCheck(TRUE) to all affected entity queries:
- recently_read_cron() in recently_read.module
- getRecords() method in RecentlyReadService.php
This is required since Drupal 9.4+, and mandatory in Drupal 10.
This patch takes up the old patch and adds the fix to it for the getRecords() methodโ The patch is tested and works with Composer patching.
Thanks for maintaining the module!
Best regards,