- Issue created by @lokeshsahu
lukasz.tyc โ made their first commit to this issueโs fork.
- @lukasztyc opened merge request.
- First commit to issue fork.
- @hashkite opened merge request.
- Status changed to Needs review
almost 2 years ago 2:26pm 30 May 2023 - ๐ฎ๐ณIndia ravi kant Jaipur
The changes of branch "3361765-footer-menus-overlapping" is working as accepted. Attaching screen shot.
- ๐ฎ๐ณIndia Akshay kashyap
Thanks for the work to fix the overlap issue, but the footer needs to be stayed. I've attached the screenshot. Please check
The footer doesn't look good now and needs more style to look attractive.
Thanks - Status changed to Needs work
almost 2 years ago 7:28am 31 May 2023 - Assigned to sandip poddar
- Merge request !58Issue #3361765: Footer menus overlapping and overflowing issue โ (Open) created by Unnamed author
After rebase the Footer was looking like this below
So i change the layout of Footer in its twig file and added styling according to it. Please review the changes :)
- ๐ฎ๐ณIndia sdhruvi5142
Hi,
I've applied the MR!58 successfully for drupal core 10.3 and it isn't working as expected.Steps I followed for testing:
1. Install the Kite 9 & 10 Drupal 10 Theme
2. Create footer Links
3. Added the footer in Block Layout and save
4. Go to Homepage and observe the changes thereTesting Result:
Here after applying the patch, not able to see the style of footer as expected. Keeping this in need review for further review.Attaching screenshot for reference
Status: Needs Review Hi @sdhruvi5142, Can you please recheck on your side and dont forget to checkout to this branch
3361765-footer-menus-overlapping
. I again cloned the Fork repo on my local and checkout to the issue branch and get the suggested changes as usual.