- Issue created by @drunken monkey
- Assigned to sayan_k_dutta
- Merge request !217Issue #3489482: Added hook class implementation for hooks in .module files. → (Closed) created by sayan_k_dutta
- Merge request !218Issue #3489482: Added hook class implementation for hooks in .module files. → (Open) created by sayan_k_dutta
- 🇮🇳India sayan_k_dutta
sayan_k_dutta → changed the visibility of the branch 3489482-switch-to-oop to hidden.
- 🇮🇳India sayan_k_dutta
sayan_k_dutta → changed the visibility of the branch 3489482-switch-to-oop to active.
- 🇮🇳India sayan_k_dutta
Working further to convert the views_hooks in oop implementation.
- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks a lot for your work on this, great job so far! However, there are still a couple of problems, as evidenced by the failing tests:
- I think
SearchApiViewHooksis missing aservices.ymlentry. - (I’d also call that class
SearchApiViewsHooks, as the module name is “Views”.) - I don’t think we can use
autowireyet, but I just temporarily enabled testing against other Drupal versions in the fork to validate that assumption. - Services in the two
Hooksclasses should be accessed via dependency injection (which is also whyautowirewould even be needed, I think), not via the global\Drupalclass. As a rule, classes that are able to use dependency injection should not contain the string'\Drupal::'.
I already implemented the first two items, but please address the last one as well as the failing MR pipelines.
- I think