if a user is activated, deactivated by the module, and reactivated by an admin, reset their expiration period

Hi,

By when we can expect this change mereged to 2.x and a new release or if this is an expected behaviour and not a bug so good to use patch instead.

Thanks!!

Patch for 2.x release.

Hi sahil.sharma@io-media.com I'll add this to the plan for the next release. Thanks! The patch looks ok to me, so feel free to use it until then.

trackleft2 → changed the visibility of the branch 8.x-1.x to hidden.

The PHPUnit test introduced in this MR does not appear to adequately test this functionality.

I say this because the https://git.drupalcode.org/project/user_expire/-/jobs/5542470 test passed with or without the fix. Running the "Test Only Changes" test should fail but it does not.

I've added test for the changes please review

trackleft2 → changed the visibility of the branch 2855005-reset-expiry-on-reactivation-7x to hidden.

I've tested this, and it appears to work as expected.

I don't think the proposed solution is the best one. I can imagine that updating the LastAccess value for a user can be problematic in some scenarios. This way, we completely lose information that a particular user has never logged in to our system.

Thank you for your comment @rafal.sereda, should we also check if the user has ever logged in before setting the value?

Automatically closed - issue fixed for 2 weeks with no activity.