- Issue created by @jakegibs617
- 🇺🇸United States jakegibs617
public static function basePath(?\SplString $site_path = NULL) { return static::baseUrl(); }
adding the ? before \SplString, marks the parameter as nullable
dhruv.mittal → changed the visibility of the branch 3.0.x to hidden.
dhruv.mittal → changed the visibility of the branch 3.0.x to active.
dhruv.mittal → changed the visibility of the branch 3508999-parameter-as-nullable-is-deprecated to hidden.
- 🇮🇳India lavanyatalwar
Patch #6 🐛 Implicitly marking parameter $site_path as nullable is deprecated Active looks good, but since using patches is not preferred, we need a MR instead.
- Status changed to Needs work
about 1 month ago 6:24am 16 June 2025 - First commit to issue fork.
- 🇮🇳India divyansh.gupta Jaipur
Thanks for the MR!
However, the .gitlab-ci.yml file added doesn't seem to be relevant to this issue, which is just about updating the method signature for deprecation compatibility.
Could you please remove this file from the MR?
Once done, we can move this forward toward RTBC. @divyansh.gupta please review I have removed .gitlab-ci.yml file. Now all the changes are only related to this issue.
- 🇮🇳India divyansh.gupta Jaipur
The changes looks good to me,
Moving this to RTBC!!