🇺🇸United States @jonraedeke

I created an MR for review based on the comment by steve Jones in #7.

This working really well for me.

jonraedeke → changed the visibility of the branch 8.x-1.x to hidden.

jonraedeke → made their first commit to this issue’s fork.

The latest patch works well. Just need to resave existing images with stale alt text and make a small change.

Thank you for this patch! I ran into the same issue with the missing start and end parameters in v1.1.x.

I use a views exposed filter and remove the start and end date inputs in the template. When a user chooses a filter value, the start and end parameters are not in the url. Starting with v1.1.x, this reverts the date back to 1969.

/calendar -> /calendar-feed?start=2025-02-23T00%3A00%3A00-05%3A00&end=2025-04-06T00%3A00%3A00-04%3A00

/calendar?s=&t=1234&c=All&o=All -> /calendar-feed?s=&t=7928&c=All&o=All&start=1969-11-30T00%3A00%3A00-05%3A00&end=1970-01-11T00%3A00%3A00-05%3A00

This patch is working really well. Thank you for doing this work, it's a major improvement. Previously, CKEditor5 was not triggering a change when "Run only on form change" was enabled.

One minor suggestion is to change the label for this option to "Run on form change" since it no longer uses "The interval to use for triggering autosave in milliseconds." setting when enabled.

Patch #14 works for me on 2.0.9.

Patch #15 doesn't change anything from #14 apart from indenting as far as I can tell.

Patch #16 doesn't apply cleanly for me.

Thank you for the quick fix Aljoša! It works well and diff looks good. RTBC

jonraedeke → created an issue.

Using the change in this MR and one additional patch mentioned in https://www.drupal.org/project/linkit_media_library/issues/3329877#comme... 📌 Not compatible with Ckeditor5 Needs review works really well for me.

Setup

Drupal 10.3.10
Linkit 6.1.6
Linkit Media 1.0.3

Patches

• Not compatible with Ckeditor5 https://www.drupal.org/project/linkit_media_library/issues/3329877: → https://git.drupalcode.org/project/linkit_media_library/-/merge_requests...
• linkit_media_library.opener.editor must be an instance of MediaLibraryOpenerInterface https://www.drupal.org/project/linkit_media_library/issues/3461637: → https://www.drupal.org/files/issues/2024-08-15/3461637-instance-of-media... →

RTBC

jonraedeke → created an issue.

This feature would be extremely useful! Thank you for this work! The fork and sandbox module work really well.

I encountered this as well, but I think this MR needs to be refactored since there is a merge issue.

jonraedeke → created an issue.

It seems like a bug if a user can assign new media to a section they don't have access to.

jonraedeke → created an issue.

I figured out why the timer never gets reset after the initial one times out when the module is configured to "Logout user regardless of activity". The cookie with HttpOnly configured to true cannot be accessed by js, so var login_time = cookies.get("Drupal.visitor.autologout_login"); is undefined.

So the HttpOnly setting is currently incompatible with the "Logout user regardless of activity" setting.

Just a note to say this is working really well and I like the UI.

Thanks for your work on this module. Any movement toward a new release? It's getting tough to track the various patches.

There appears to be something wrong with the logic. After the initial timeout, the user is presented with a dialog on every page request. I have it set to "Logout user regardless of activity".

This is working really, except that the settings form always reverts back to the default value for cookie lifetime. To replicate, change the value to `0` and save. The form will show `31536000`.

Patch #28 and #29 both fix my issue. I'm not sure which is the best approach.

In my case, default contextual filters that happen to be null because the field was not required were causing this fatal error.

jonraedeke → created an issue.

Unfortunately, this is still an issue with CKEditor 5 implementation in core.

I'm just digging into CKEditor 5 plugin coding, but it appears that CKEditor 5 really isn't aware of the media markup.

#42 Works well for D9. Thanks!

Works great and code looks good. Thank you! RTBC!

jonraedeke → created an issue.

jonraedeke → created an issue.

jonraedeke → made their first commit to this issue’s fork.

Thank you for the clarification! This works really well for me and I think it will come in handy for others.

Great point about introducing a breaking change. I was not successful using {{ title_value }} as a replacement. I still get the encoded ampersand. I was also not successful in stripping tags using the raw option for the title field. Javascript is visible, but does not execute.

Fantastic idea to make this an Advanced Drupal setting! This would be a huge convenience for us.

I tried the latest MR and I'm not seeing the purpose of the raw_title_field: 'rawTitle' setting as it doesn't seem to control anything currently. I guess we would need to separate out the rendering from the sanitizing. Even if we do, is there a case where the title would not be title?

Sidenote: In the js, it seems as though info[rawTitleField] is always undefined so that always passes !== false.

I added an MR for another approach that works with either plain text or raw title in the json feed. Basically, just sanitize and render the event title. This would just work out of the box and not require additional configuration.

I don't see where this module sanitizing the title though. Is there a reason it is rendering and sanitizing the description and not the title?

The patch doesn't work in my case since I am using the HTML Title module and there are a few other things happening here. It does seem like I'll have to create a custom field formatter.

Thank you codebymikey and mingsong. I discovered my issue with the json feed from views. In the REST export: Row style options, you can check a box to enable "Raw". This fixes it.

jonraedeke → created an issue.

I just figured it out. I saw in the network inspector that it was actually grabbing the json data url with the start and end parameters. I just needed to add the exposed filters and name them accordingly. Sorry if I missed this in the docs or if it's obvious.

Example for anyone else who has the same question:
/event-feed?start=2023-01-01T00%3A00%3A00-05%3A00&end=2023-02-12T00%3A00%3A00-05%3A00

jonraedeke → created an issue.