- Issue created by @Peacog
- Merge request !22Issue #3362940: Improve visibility when using Gin vertical and modern horizontal toolbars β (Open) created by Peacog
- Status changed to Needs review
over 1 year ago 11:57am 26 May 2023 - πͺπΈSpain Peacog
The MR adds the proposed change. It looks like this:
Wide screens
Narrow screens
I think the style has changed in meantime?
I'd suggest to preserve the great design, something like this:
Oh, lol. Didn't noticed, this is already the exact implementation. We just switched to the modern Gin bar.
So @Peacog, what do you think? Can we close this?
- πͺπΈSpain Peacog
Hi @thomas.frobieter. The patch is to improve visibility when you're using the sidebar, vertical toolbar. With the vertical toolbar the indicator color strip is down the left side of the screen, not across the top. It looks like this (without the patch)
It doesn't stand out much and is easy to miss on a busy screen.
- Assigned to thomas.frobieter
- Status changed to Needs work
about 1 year ago 4:06pm 22 September 2023 True, so lets colorize the menu item like suggested! I'll update the issue fork.
Blocked by π Fix GIN Admin Toolbar Style: Secondary toolbar is overlapped by the 3px of the indicators border-top Fixed - this needs to be merged to DEV first.
- πΊπΈUnited States DamienMcKenna NH, USA
The other issue was committed, so this work can continue now.
- π©πͺGermany metalbote Aachen
I stumbled across the following small flaw with the bottom border radius, my commit fixes it.
Current:
After:
Hovered version, and within will be same as before. - πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
Please check out the refactoring of how libraries add style for the environment indicator in π Update module to use CSS variables instead of adding inline CSS. Active , and possibly review that MR. Any changes here, will also need to be done there.