- Issue created by @alshami
- Issue was unassigned.
- Status changed to Needs review
8 months ago 10:45am 16 March 2024 - last update
8 months ago 1 pass - Status changed to Needs work
5 months ago 5:33am 19 June 2024 - 🇬🇧United Kingdom scott_euser
Thanks for the work on this! A few things:
- Can this be converted to a merge request to make it easier to review and comment please? + so tests run
- This needs test coverage, which can be added to ViewsReferenceSettingsTest.php
- First commit to issue fork.
- Merge request !60Issue #3427005: Add hide header option to extra settings. → (Merged) created by manish-31
- Status changed to Needs review
5 months ago 2:23pm 19 June 2024 - 🇮🇳India manish-31
Patch #2 did not work for me, in my case there was no value in
$view->display_handler->options['header']. I believe$view->display_handler->getOption('header')would be a good choice and safe option.Opened MR that includes test coverage for hide header option and the above change. Needs review. Thanks!
-
scott_euser →
committed 822b6b1d on 8.x-2.x authored by
manish-31 →
Issue #3427005: Hide header option
-
scott_euser →
committed 822b6b1d on 8.x-2.x authored by
manish-31 →
- Status changed to Fixed
5 months ago 5:07am 20 June 2024 - 🇬🇧United Kingdom scott_euser
Great stuff, thank you! Did a round of manual testing as well and all working as expected. Thank you for adding the test coverage as well.
Automatically closed - issue fixed for 2 weeks with no activity.