- Issue created by @joegraduate
- Merge request !9Issue #3457459 by joegraduate: GitLabCI: Fix existing PHPCS issues → (Merged) created by joegraduate
- Issue was unassigned.
- Status changed to Needs review
8 months ago 12:00am 27 June 2024 - 🇺🇸United States joegraduate Arizona, USA
Decided it'd be easier to tackle PHPCS and PHPStan issues together since there is some overlap.
- 🇺🇸United States joegraduate Arizona, USA
Moved method deprecations changes to 📌 Deprecate ConfigProviderBase drupalGetPath() and drupalGetProfile() methods Active .
- 🇵🇭Philippines paraderojether
Hi
I reviewed MR!9, and confirmed PHPCS & PHPStan issues are fixed on the Gitlab CI
However, I noticed a phpcs issue using PHP_CodeSniffer:
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig config_provider FILE: /Users/jetherparadero/Q1/q1contributions/web/modules/contrib/config_provider/src/ConfigProviderConfigInstaller.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\config_provider\Plugin\ConfigCollectorInterface. ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1contributions/web/modules/contrib/config_provider/src/Plugin/ConfigCollector.php ----------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\StorageInterface. ----------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------- Time: 391ms; Memory: 10MB
Command used:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig config_provider
Kindly check and advise, please.
Thank you. - 🇮🇳India akulsaxena
Hi @paraderojether
Since Gitlab CI has been added to Drupal, It is used to find errors for coding standards. If the pipeline is passing, re-run the pipeline to test that it is passing and if the job succeeds, the standards are considered correct.
You can re-run the pipeline on this issue and if it passes, feel free to move it to RTBC+ - 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
All tests are passing, additionally, the gitlab-ci.yml update and dependency injection updates look good to me.
-
joegraduate →
committed 932a457a on 3.0.x
Issue #3457459 by joegraduate, paraderojether, akulsaxena, trackleft2:...
-
joegraduate →
committed 932a457a on 3.0.x
Automatically closed - issue fixed for 2 weeks with no activity.