Account created on 30 March 2011, almost 14 years ago
#

Merge Requests

Recent comments

🇺🇸United States j_s

This change is nice for regular filters, but as far as I can tell, something is still needed for contextual filters. Issue Contextual filter for month Active is related to that.

🇺🇸United States j_s

I'm also wondering this but for making a contextual filter for just Year. I want a URL like /myview/2020 where 2020 goes into a Smart Date-based contextual filter and shows results just for 2020. Is this possible yet?

🇺🇸United States j_s

Using MR10 I now get:
Drupal\Core\Database\IntegrityConstraintViolationException: SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'startDatePager' in field list is ambiguous

🇺🇸United States j_s

I couldn't get MR9 applied. It might be that it needs to be against 2.0.x instead of 8.x-1.x.

🇺🇸United States j_s

I tried the patch and get this error:
Drupal\Core\Database\IntegrityConstraintViolationException: SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'startDate' in field list is ambiguous

🇺🇸United States j_s

This change works fine for me. Thanks!

🇺🇸United States j_s

Also tested #466 and have the same issue with it as #467 on Drupal 10.3.6. I moved around the filter order and cleared cache with no success.

🇺🇸United States j_s

+1 for CKBox. Or otherwise getting its image editor into Drupal somehow would be great.

🇺🇸United States j_s

In my case it's Apache. I'm not sure about proxy details.

🇺🇸United States j_s

With #13's updated MR I get this whitescreen error:

TypeError: Drupal\views_ical\Plugin\views\style\IcalWizard::setVTimezone(): Argument #1 ($vTimezone) must be of type Drupal\views_ical\Plugin\views\style\Eluceo\iCal\Component\Timezone, Eluceo\iCal\Component\Timezone given, called in /modules/contrib/views_ical/src/ViewsIcalHelper.php on line 407 in Drupal\views_ical\Plugin\views\style\IcalWizard->setVTimezone() (line 116 of /modules/contrib/views_ical/src/Plugin/views/style/IcalWizard.php).

If I change $style->setVTimezone(new Timezone($tz)); back to $style->vTimezone = new \Eluceo\iCal\Component\Timezone($tz); it works again.

The deprecation warning I posted previously seems to nicely be gone.
The next deprecated warning is given:

Deprecated function: Creation of dynamic property Drupal\views_ical\Plugin\views\style\IcalWizard::$usedTimezoneTransitions is deprecated in Drupal\views_ical\ViewsIcalHelper->addTimezone() (line 347 of /modules/contrib/views_ical/src/ViewsIcalHelper.php)

🇺🇸United States j_s

Patch #21 works well for me on Drupal 10.3, thanks!

🇺🇸United States j_s

I'm also getting this issue. Would be good to remove x-powered-by.

🇺🇸United States j_s

Something like that could work. Really anything to try would be better than nothing.

🇺🇸United States j_s

With a field of type Number, I'm not sure what the current purpose of it is when adding a price to it. A user is presented the open number field to enter their own number, and the price just adds a singular value to the total. My thought would be to multiply number field by default. But of course, there could be some scenario where someone needs it as-is.

I would propose a checkbox to enable multiply on certain fields, at least on the Number field. I can imagine a dropdown being useful to select a number instead of having an open number field but can't guarantee the values of the dropdown options are numeric to be able to multiply by.

I'm not sure multiply is needed on radios or checkboxes.

A handler could be ok if it can show the breakout of quantity multiplied by cost on the checkout page.

🇺🇸United States j_s

The updated MR did resolve the warning (thanks!) but it looks like there's more. Not sure how many more there will be.

Deprecated function: Creation of dynamic property Drupal\views_ical\Plugin\views\style\IcalWizard::$checktransitions is deprecated in Drupal\views_ical\ViewsIcalHelper->addTimezone() (line 349 of /modules/contrib/views_ical/src/ViewsIcalHelper.php)

🇺🇸United States j_s

This MR now produces an error for me:
Error: Cannot access protected property Drupal\views_ical\Plugin\views\style\IcalWizard::$vTimezone in Drupal\views_ical\ViewsIcalHelper->addTimezone() (line 409 of /modules/contrib/views_ical/src/ViewsIcalHelper.php).

🇺🇸United States j_s

Patch in #3 fixed the error for me. Thanks!

🇺🇸United States j_s

Also confirming that the MR fixed the issue for me on PHP 8.3. Thanks!

🇺🇸United States j_s

I was able to post my issue at Improve Drupal core issue version guidance and selection Active .

🇺🇸United States j_s

Thanks for pointing me in the right direction!

🇺🇸United States j_s

@cilefen Then please do not change issue information when the report is not meant for 11.x and there is no information in the issue creation workflow to indicate that new issues must only be against 11.x.

🇺🇸United States j_s

Will say occasionally there are issues that target older branches. But know almost all have to land in 11.x first.

Are there really issues permitted that target Drupal 4.6.x-dev?

It should be made more obvious in initial issue creation that even if someone finds an issue in the latest stable release, it actually needs to be replicated in the latest unreleased major version up. You didn't even consider it a potential backport issue initially and just switched it to 11 from the get-go, which is not what I was reporting. But now at least this issue can be seen across the board.

🇺🇸United States j_s

Confirmed on Drupal 11.0-dev. I installed on DDEV v1.23.2 with PHP 8.3.8 using:
ddev composer create drupal/recommended-project:11.x-dev@dev

Using the same steps to reproduce in the original post, I get this warning:

Warning: Undefined array key 1 in template_preprocess_html() (line 1176 of core/includes/theme.inc).
template_preprocess_html(Array, 'html', Array)
call_user_func_array('template_preprocess_html', Array) (Line: 261)
Drupal\Core\Theme\ThemeManager->render('html', Array) (Line: 446)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 203)
Drupal\Core\Render\Renderer->render(Array) (Line: 158)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 153)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object) (Line: 246)
Symfony\Component\EventDispatcher\EventDispatcher::Symfony\Component\EventDispatcher\{closure}(Object, 'kernel.view', Object) (Line: 206)
Symfony\Component\EventDispatcher\EventDispatcher->callListeners(Array, 'kernel.view', Object) (Line: 56)
Symfony\Component\EventDispatcher\EventDispatcher->dispatch(Object, 'kernel.view') (Line: 188)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 2) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 2, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 2, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 2, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 2, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 2, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 2, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 2, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 2, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 2, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 2, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 2) (Line: 166)
Drupal\Core\EventSubscriber\DefaultExceptionHtmlSubscriber->makeSubrequest(Object, '/system/404', 404) (Line: 122)
Drupal\Core\EventSubscriber\DefaultExceptionHtmlSubscriber->on404(Object) (Line: 109)
Drupal\Core\EventSubscriber\HttpExceptionSubscriberBase->onException(Object, 'kernel.exception', Object) (Line: 246)
Symfony\Component\EventDispatcher\EventDispatcher::Symfony\Component\EventDispatcher\{closure}(Object, 'kernel.exception', Object) (Line: 206)
Symfony\Component\EventDispatcher\EventDispatcher->callListeners(Array, 'kernel.exception', Object) (Line: 56)
Symfony\Component\EventDispatcher\EventDispatcher->dispatch(Object, 'kernel.exception') (Line: 241)
Symfony\Component\HttpKernel\HttpKernel->handleThrowable(Object, Object, 1) (Line: 91)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 709)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

🇺🇸United States j_s

Ah, is there a reason all the past dev versions can still be selected for new issues? It's confusing when creating a new issue to have them available to select when you say issues and fixes need to be based in the latest dev version. The others should not be available to select. Perhaps I'll open an issue about that for improving Drupal issue reporting user experience.

For this issue, I'll take a look at 11 and report back if I can reproduce or if this issue can be closed.

🇺🇸United States j_s

The steps to reproduce are accurate from my original post for 10.3.0-rc1. I have installed it on simplytest.me and locally on ddev and can get the warning right away with the steps already outlined.

🇺🇸United States j_s

For anyone interested, I think I was able to get things situated:

mymodule/mymodule.services.yml

services:
  # Subscriber to the event we dispatch in hook_order_item.
  mymodule_order_item:
    class: '\Drupal\mymodule\EventSubscriber\OrderItemSubscriber'
    tags:
      - { name: 'event_subscriber' }

mymodule/src/EventSubscriber/OrderItemSubscriber.php

<?php

namespace Drupal\mymodule\EventSubscriber;

use Drupal\commerce_order\Entity\OrderItem;
use Drupal\webform_product\Event\OrderItemEvent;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
 * Class OrderItemSubscriber.
 *
 * @package Drupal\mymodule\EventSubscriber
 */
class OrderItemSubscriber implements EventSubscriberInterface {

  /**
   * {@inheritdoc}
   */
  public static function getSubscribedEvents() {
    return [
      // Static class constant => method on this class.
      OrderItemEvent::EVENT_NAME => 'onOrderItem',
    ];
  }

  /**
   * Subscribe to the order item event dispatched.
   *
   * @param \Drupal\webform_product\Event\OrderItemEvent $event
   *   Our custom event object.
   */
  public function onOrderItem(OrderItemEvent $event) {

    $webform = $event->webformSubmission->toArray();

    if ($webform['webform_id'][0]['target_id'] == 'mywebform_id') {
      $dinner_count = $event->webformSubmission->getElementData('dinner_count');
      if ($dinner_count > 0) {
        $event->orderItems[] = OrderItem::create([
          'type' => 'webform',
          'title' => 'Dinner guest count (' . $dinner_count . ' entries at $20 ea)',
          'quantity' => $dinner_count,
          'unit_price' => [
            'number' => 20,
            'currency_code' => 'USD',
          ],
        ]);
      }
    }
  }
}
🇺🇸United States j_s

Is there an example that could be provided for making this request a possibility? Just posting a link to the event subscriber source and long documentation to how event subscribers work isn't very helpful.

Going further, I believe it would be better if the number field could automatically multiply by the price of the field instead of making people custom code a solution that should be an obvious inclusion. Quantity and multiplying cost by that quantity is a very common scenario for checkout systems.

🇺🇸United States j_s

joshuasosa changed the visibility of the branch 3263728-allow-customer-to to hidden.

🇺🇸United States j_s

I would like this ability as well. I would think it should be built-in that if a number field is used, the price attached to the field should automatically multiply by the number entered. Or add a checkbox to enable that capability.

As it is, the only thing I could see is the suggestion to custom code an order item event per #3256022: Number field Price multiply from user input? .

🇺🇸United States j_s

joshuasosa made their first commit to this issue’s fork.

🇺🇸United States j_s

Thanks for reviewing! I'm not currently sure about steps to reproduce. The issue I encountered might stem from a migration from D7 to D9/10.

🇺🇸United States j_s

In my particular case, a visitor went to mysite.com/index.php) which causes a white screen error. #46 didn't work for me but #56 resolved the issue.

🇺🇸United States j_s

I have a custom theme for the front-end but use Claro for admin theme.

In mytheme.gutenberg.yml I tried using your syntax:

- theme-support:
  - __experimentalFeatures:
    - typography:
      - fontSizes:
        - theme:
          - name: "Small"
            slug: "small"
            size: 14
          - name: "Lead"
            slug: "lead"
            size: 20
          - name: "Display 1"
            slug: "display-1"
            size: 96
          - name: "Display 2"
            slug: "display-2"
            size: 88
          - name: "Display 3"
            slug: "display-3"
            size: 72
          - name: "Display 4"
            slug: "display-4"
            size: 56

That didn't seem to work, so I tried without the hyphens:

theme-support:
  __experimentalFeatures:
    typography:
      fontSizes:
        theme:
          - name: "Small"
            slug: "small"
            size: 14
          - name: "Lead"
            slug: "lead"
            size: 20
          - name: "Display 1"
            slug: "display-1"
            size: 96
          - name: "Display 2"
            slug: "display-2"
            size: 88
          - name: "Display 3"
            slug: "display-3"
            size: 72
          - name: "Display 4"
            slug: "display-4"
            size: 56

That worked and I can see a dropdown of my specified font sizes.

I was also able to get custom colors in like this:

theme-support:
  __experimentalFeatures:
    color:
      background: true
      button: true
      caption: true
      defaultDuotone: false
      defaultGradients: false
      text: true
      defaultPalette: false
      heading: true
      link: true
      palette:
        theme:
          - slug: "blue"
            name: "Blue"
            color: "#0000FF"
          - slug: "red"
            name: "Red"
            color: "#CC0000"

Thanks!

🇺🇸United States j_s

Attached is a patch that just checks if the resulting URL is empty before performing the redirect response. This fixes the issue for me, but it could also be good to figure out how to prevent the issue from happening in the first place.

🇺🇸United States j_s

Another temporary workaround is to not use the case transformation dropdown options in the contextual filter and instead use Twig to make adjustments when referring to the filter. For example, a contextual filter for seasons could override the view title and capitalize with something like {{ arguments.field_season_value|capitalize }}. (If needing to override view title with Twig filters, patch #7 in Change "Override title" field type from textfield to textarea Needs work can expand the maxlength.)

🇺🇸United States j_s

Tested patch #7 and confirmed it works in 10.2, thanks!

🇺🇸United States j_s

I think this patch needs to be rerolled.

🇺🇸United States j_s

I'm also unable to get font sizes to work with the provided instructions. It just shows the default set of font size options.

🇺🇸United States j_s

I'm not sure how to solve, but leo in #66 had a note about headers being the cause. I'm also unsure how to test anymore: testing again on Windows 10 Ubuntu WSL in alpine, my Terminal and PowerShell allow clicking on links in alpine, meaning it seems to work ok. There may be a combination of another version of Linux and mail client where it doesn't work properly.

Perhaps someone that still encounters the issue could provide details about platform and email client used to help replicate for fixing and testing.

🇺🇸United States j_s

Ah that does look like the same sort of issue with dependency list likely not updating. Added a comment in #3229138. Thanks!

🇺🇸United States j_s

Same issue occurring with the plugin provided by views_ical module. 🐛 Uninstall wants to delete whole view Active

🇺🇸United States j_s

Testing the patch in #6 gives these warnings:

Warning: Undefined array key "timezone_override" in Drupal\views_ical\Plugin\views\row\IcalFieldsWizard->render() (line 88 of /web/modules/contrib/views_ical/src/Plugin/views/row/IcalFieldsWizard.php)
#0 /web/core/includes/bootstrap.inc(164): _drupal_error_handler_real()
#1 /web/modules/contrib/views_ical/src/Plugin/views/row/IcalFieldsWizard.php(88): _drupal_error_handler()
#2 /web/core/modules/views/src/Plugin/views/style/StylePluginBase.php(504): Drupal\views_ical\Plugin\views\row\IcalFieldsWizard->render()
#3 /web/core/modules/views/src/Plugin/views/style/StylePluginBase.php(464): Drupal\views\Plugin\views\style\StylePluginBase->renderGroupingSets()
#4 /web/modules/contrib/views_ical/src/Plugin/views/style/IcalWizard.php(250): Drupal\views\Plugin\views\style\StylePluginBase->render()
#5 /web/core/modules/views/src/Plugin/views/display/Feed.php(190): Drupal\views_ical\Plugin\views\style\IcalWizard->render()
#6 /web/core/modules/views/src/ViewExecutable.php(1548): Drupal\views\Plugin\views\display\Feed->render()
#7 /web/core/modules/views/src/Plugin/views/display/Feed.php(173): Drupal\views\ViewExecutable->render()
#8 /web/core/modules/views/src/ViewExecutable.php(1677): Drupal\views\Plugin\views\display\Feed->preview()
#9 /web/core/modules/views_ui/src/ViewUI.php(612): Drupal\views\ViewExecutable->preview()
#10 /web/core/modules/views_ui/src/ViewPreviewForm.php(62): Drupal\views_ui\ViewUI->renderPreview()
#11 /web/core/lib/Drupal/Core/Entity/EntityForm.php(107): Drupal\views_ui\ViewPreviewForm->form()
#12 /web/core/modules/views_ui/src/ViewFormBase.php(41): Drupal\Core\Entity\EntityForm->buildForm()
#13 [internal function]: Drupal\views_ui\ViewFormBase->buildForm()
#14 /web/core/lib/Drupal/Core/Form/FormBuilder.php(536): call_user_func_array()
#15 /web/core/lib/Drupal/Core/Form/FormBuilder.php(375): Drupal\Core\Form\FormBuilder->retrieveForm()
#16 /web/core/lib/Drupal/Core/Form/FormBuilder.php(633): Drupal\Core\Form\FormBuilder->rebuildForm()
#17 /web/core/lib/Drupal/Core/Form/FormBuilder.php(325): Drupal\Core\Form\FormBuilder->processForm()
#18 /web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm()
#19 [internal function]: Drupal\Core\Controller\FormController->getContentResult()
#20 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#21 /web/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#22 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext()
#23 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
#24 /vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#25 /vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#26 /web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle()
#27 /web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#28 /web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#29 /web/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle()
#30 /web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle()
#31 /web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
#32 /web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle()
#33 /web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#34 /web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#35 /web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle()
#36 /web/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
#37 /web/index.php(19): Drupal\Core\DrupalKernel->handle()
#38 {main}

🇺🇸United States j_s

Alpine is apparently still supported by its developer. It's a valid text-only mail client for linux systems. This issue did exist in Alpine last I checked a year ago and was originally reported by a client of mine that uses Alpine exclusively. Anyone interested in fixing the issue could download and install Alpine to try themselves.
https://alpineapp.email/
https://repo.or.cz/alpine.git

That being said, we could say Drupal does not support text-only mail clients.

🇺🇸United States j_s

The way I was able to reproduce the error is related to views contextual filters being fed into views_field_view. There could be other ways to instigate the error, but these steps are based on my real-world case.

1. Create a content type and add a select list field to it with some options (e.g., Season with options Spring, Summer, Fall, Winter). It could also be set up as something else, like taxonomy or entity reference, just something to use as a 'category'.
2. Create a view with the new content type using fields with a page using a path like /test/% and a block.
3. Have the Title field shown on both displays just to show something.
4. Add a contextual filter for the list field (e.g., Season) on both displays with a default to display all results.
5. On the page display, set the list field's contextual filter to Case: Capitalize first letter. This could also be set to the other options.
6. On the page display, add a view field view (i.e., Global: View) field.
7. In the view field, set the view to the current view and the display to the other block in this view.
8. Set the contextual filters to the arguments.list field that comes from the page (e.g., {{ arguments.field_list_value }} )
6. Save and update the preview. The error log shows the error every time you update preview.

The error can go away if we set the page's contextual filter to not alter the case or if we remove the page's views field view. But neither workaround is ideal.

Using raw_arguments generates another series of views_field_view related errors:

Warning: Undefined array key 0 in Drupal\views_field_view\Plugin\views\field\View->getTokenValue() (line 318 of /modules/contrib/views_field_view/src/Plugin/views/field/View.php)
#0 /core/includes/bootstrap.inc(164): _drupal_error_handler_real(2, 'Undefined array...', '/var/www/html/w...', 318)
#1 /modules/contrib/views_field_view/src/Plugin/views/field/View.php(318): _drupal_error_handler(2, 'Undefined array...', '/var/www/html/w...', 318)
#2 /modules/contrib/views_field_view/src/Plugin/views/field/View.php(231): Drupal\views_field_view\Plugin\views\field\View->getTokenValue('{{ raw_argument...', Object(Drupal\views\ResultRow), Object(Drupal\views\ViewExecutable))
#3 /core/modules/views/src/Plugin/views/field/FieldPluginBase.php(1196): Drupal\views_field_view\Plugin\views\field\View->render(Object(Drupal\views\ResultRow))
#4 /core/modules/views/views.theme.inc(238): Drupal\views\Plugin\views\field\FieldPluginBase->advancedRender(Object(Drupal\views\ResultRow))
#5 [internal function]: template_preprocess_views_view_field(Array, 'views_view_fiel...', Array)
#6 /core/lib/Drupal/Core/Theme/ThemeManager.php(261): call_user_func_array('template_prepro...', Array)
#7 /core/lib/Drupal/Core/Render/Renderer.php(480): Drupal\Core\Theme\ThemeManager->render('views_view_fiel...', Array)
#8 /core/lib/Drupal/Core/Render/Renderer.php(240): Drupal\Core\Render\Renderer->doRender(Array, false)
#9 /core/modules/views/src/Plugin/views/field/FieldPluginBase.php(1790): Drupal\Core\Render\Renderer->render(Array)
#10 /core/modules/views/src/Plugin/views/style/StylePluginBase.php(765): Drupal\views\Plugin\views\field\FieldPluginBase->theme(Object(Drupal\views\ResultRow))
#11 [internal function]: Drupal\views\Plugin\views\style\StylePluginBase->elementPreRenderRow(Array)
#12 /core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(111): call_user_func_array(Array, Array)
#13 /core/lib/Drupal/Core/Render/Renderer.php(859): Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_ren...', 'exception', 'Drupal\\Core\\Ren...')
#14 /core/lib/Drupal/Core/Render/Renderer.php(421): Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array)
#15 /core/lib/Drupal/Core/Render/Renderer.php(240): Drupal\Core\Render\Renderer->doRender(Array, true)
#16 /core/lib/Drupal/Core/Render/Renderer.php(165): Drupal\Core\Render\Renderer->render(Array, true)
#17 /core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}()
#18 /core/lib/Drupal/Core/Render/Renderer.php(166): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#19 /core/modules/views/src/Plugin/views/style/StylePluginBase.php(707): Drupal\Core\Render\Renderer->renderPlain(Array)
#20 /core/modules/views/src/Plugin/views/style/StylePluginBase.php(570): Drupal\views\Plugin\views\style\StylePluginBase->renderFields(Array)
#21 /core/modules/views/src/Plugin/views/style/StylePluginBase.php(461): Drupal\views\Plugin\views\style\StylePluginBase->renderGrouping(Array, Array, true)
#22 /core/modules/views/src/Plugin/views/display/DisplayPluginBase.php(2174): Drupal\views\Plugin\views\style\StylePluginBase->render()
#23 /core/modules/views/src/ViewExecutable.php(1548): Drupal\views\Plugin\views\display\DisplayPluginBase->render()
#24 /core/modules/views/src/Plugin/views/display/DisplayPluginBase.php(2464): Drupal\views\ViewExecutable->render()
#25 /core/modules/views/src/ViewExecutable.php(1677): Drupal\views\Plugin\views\display\DisplayPluginBase->preview()
#26 /core/modules/views_ui/src/ViewUI.php(612): Drupal\views\ViewExecutable->preview('page_1', Array)
#27 /core/modules/views_ui/src/ViewPreviewForm.php(62): Drupal\views_ui\ViewUI->renderPreview('page_1', Array)
#28 /core/lib/Drupal/Core/Entity/EntityForm.php(107): Drupal\views_ui\ViewPreviewForm->form(Array, Object(Drupal\Core\Form\FormState))
#29 /core/modules/views_ui/src/ViewFormBase.php(41): Drupal\Core\Entity\EntityForm->buildForm(Array, Object(Drupal\Core\Form\FormState))
#30 [internal function]: Drupal\views_ui\ViewFormBase->buildForm(Array, Object(Drupal\Core\Form\FormState), 'page_1')
#31 /core/lib/Drupal/Core/Form/FormBuilder.php(536): call_user_func_array(Array, Array)
#32 /core/lib/Drupal/Core/Form/FormBuilder.php(375): Drupal\Core\Form\FormBuilder->retrieveForm('view_preview_fo...', Object(Drupal\Core\Form\FormState))
#33 /core/lib/Drupal/Core/Form/FormBuilder.php(633): Drupal\Core\Form\FormBuilder->rebuildForm('view_preview_fo...', Object(Drupal\Core\Form\FormState), Array)
#34 /core/lib/Drupal/Core/Form/FormBuilder.php(325): Drupal\Core\Form\FormBuilder->processForm('view_preview_fo...', Array, Object(Drupal\Core\Form\FormState))
#35 /core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm(Object(Drupal\views_ui\ViewPreviewForm), Object(Drupal\Core\Form\FormState))
#36 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch))
#37 /core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#38 /core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#39 /core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#40 /core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#41 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#42 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#43 /core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#44 /core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#45 /core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#46 /core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#47 /core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#48 /core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#49 /core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#50 /core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#51 /core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#52 /core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#53 /core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#54 /index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#55 {main}

🇺🇸United States j_s

I'm not sure how to replicate yet. I exported the form config and imported to another site and everything works fine there. Maybe there's a submission tripping it up?

I edited line 114 of /core/lib/Drupal/Core/Entity/Element/EntityAutocomplete.php to print $element['#default_value'] where it throws that error and it's giving a string of a uid, the 'submitted by' user, instead of the expected instance of EntityInterface.

🇺🇸United States j_s

According to the readme quote I posted it supposedly is. But I've tried a number of things in my custom module and can't even get a new custom checkbox validator to show up in element properties. For now I'll settle with using the built-in webform regex validator.

🇺🇸United States j_s

joshuasosa changed the visibility of the branch 3436241-creating-a-webform to hidden.

🇺🇸United States j_s

joshuasosa made their first commit to this issue’s fork.

🇺🇸United States j_s

I'm getting the same issue on 3.0.4.

🇺🇸United States j_s

Same issue as reported by 12: patch #11 produces a white-screen fatal error regarding a modulo by zero using Drupal 10.2.3 and Views Bootstrap 5.4.0.

A warning also comes up:

Warning: Undefined array key "alignment" in template_preprocess_views_view_grid() (line 715 of core/modules/views/views.theme.inc).

🇺🇸United States j_s

Deprecated function: mb_strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\Core\Config\Entity\Query\Condition->compile() (line 39 of /core/lib/Drupal/Core/Config/Entity/Query/Condition.php)

The patch provided with the MR in 3301613 📌 Only process values in config entity query conditions for values that have values Active fixed this error for me.

🇺🇸United States j_s

The change in MR!2585 fixes the error for me. Thanks!

🇺🇸United States j_s

I'm getting the same error with the asterisk meant to allow all file types. Setting a specific list of file types works at least.

🇺🇸United States j_s

The patch in #15 fixes the error for me on 2.0.x-dev. Thanks!

🇺🇸United States j_s

Attached is a temporary patch against -dev just to suppress the warnings. It'd probably be better to properly handle them, but at least my logs won't keep blowing up for now.

🇺🇸United States j_s

I'm getting same thing on 8.x-1.0-alpha12. Lots of warnings blowing up the logs to hundreds of pages. This site is for AZ, US which has no time zone change throughout the year.

Warning: Undefined array key -1 in Drupal\views_ical\ViewsIcalHelper->addTimezone() (line 380 of /drupal/web/modules/contrib/views_ical/src/ViewsIcalHelper.php)

Warning: Trying to access array offset on value of type null in Drupal\views_ical\ViewsIcalHelper->addTimezone() (line 427 of /drupal/web/modules/contrib/views_ical/src/ViewsIcalHelper.php)

Warning: Trying to access array offset on value of type null in Drupal\views_ical\ViewsIcalHelper->addTimezone() (line 435 of /drupal/web/modules/contrib/views_ical/src/ViewsIcalHelper.php)

Warning: Undefined array key -1 in Drupal\views_ical\ViewsIcalHelper->addTimezone() (line 434 of /drupal/web/modules/contrib/views_ical/src/ViewsIcalHelper.php)

Warning: Undefined array key "timezone_override" in Drupal\views_ical\Plugin\views\row\IcalFieldsWizard->render() (line 88 of /drupal/web/modules/contrib/views_ical/src/Plugin/views/row/IcalFieldsWizard.php)

🇺🇸United States j_s

I'm getting duplicate records displayed in my view on 2.1.3 due to draggableviews. Patch in #11 doesn't help.

🇺🇸United States j_s

I'm currently getting duplicates due to draggableviews on 2.1.3. Patch #51 doesn't help.

🇺🇸United States j_s

I haven't tried on 11 yet, but on 9 and 10 the issue was more than just the drop downs. It would occur for tables and other fields that get pushed out of view. The fix should be more general to cover all cases, not just a drop-down fix.

🇺🇸United States j_s

It looks like adding

if ($transition['index'] > 0) {

before $transitionPrev on 434 and closing after the !in_array if-block clears up these warnings for me.

🇺🇸United States j_s

Yes! It's for AZ time which uses MST without any daylight savings change. Putting in the suggested null check on $transitionPrev seems to clear up those warnings for me. Thanks!

🇺🇸United States j_s

MR!17 from #14 fixes the deprecated error message for me.

I'm able to add the calendar feed to my Outlook and Google Calendar using alpha12.

I'm not sure if this is a good place to put it, but I also see other warnings in logs:

Warning: Trying to access array offset on value of type null in Drupal\views_ical\ViewsIcalHelper->addTimezone() (line 435 of /drupal/web/modules/contrib/views_ical/src/ViewsIcalHelper.php)

Warning: Undefined array key -1 in Drupal\views_ical\ViewsIcalHelper->addTimezone() (line 434 of /drupal/web/modules/contrib/views_ical/src/ViewsIcalHelper.php)

🇺🇸United States j_s

Patch #17 (equivalent to MR!9 in #13) seems to work for me. Thanks!

🇺🇸United States j_s

I definitely use the per-node user permission setting a lot, so thanks for continuing to keep it integrated here!

🇺🇸United States j_s

This fix helped resolve JS issues when aggregated. Some things, like IMCE module, break due to this error. Thanks!

🇺🇸United States j_s

Patch #15 works for me. No more errors about this issue in log. Thanks!

🇺🇸United States j_s

The patch with MR!16 resolves the issue if nothing is entered in the pattern field. But it continues to generate a fatal error if a non-existent pattern or pattern using a disallowed field is used.

If a pattern is entered, maybe there should be some sort of check to verify/validate the pattern on label generation.

🇺🇸United States j_s

Hello, I can confirm that the patch in #4 works in my testing.

On Google Calendar, I previously could not subscribe or import a calendar created with views_ical's iCal Style Wizard format. For subscription, it would say the calendar was created and it's fetching events, but nothing would come up. On a direct import of the file to an existing calendar, it would say 0 out of 0 events imported. This patch fixes both of those cases. Thanks!

🇺🇸United States j_s

Just noting here that patch #11 worked well for me. I looked at the fatal error with the listed permissions and confirmed they're no longer relevant to my site, so I just wanted them gone so I can move on. The error blocked me from performing database updates or changing text format configuration, and there's no other solution listed here (not sure about 3375860 🐛 "Adding non-existent permissions to a role is not allowed." exception is thrown for profile installations Needs work ).

A patch that more carefully considers implications and possibilities would be nice, but I think #11 is good to add temporarily for getting past the issue, and then removing the patch just in case.

🇺🇸United States j_s

I also encountered this issue and patch #9 helped.

Now I have some more warnings:

Warning: Undefined array key "table" in Drupal\views\Plugin\ViewsHandlerManager->getHandler() (line 82 of core/modules/views/src/Plugin/ViewsHandlerManager.php).
Warning: Undefined array key "field" in Drupal\views\Plugin\ViewsHandlerManager->getHandler() (line 83 of core/modules/views/src/Plugin/ViewsHandlerManager.php).

I get that it may be some contributed module that isn't implementing something properly. But it might be nice for Drupal to do some isset checks so as to avoid these warnings coming up in log when they don't seemingly affect functionality. Or at least make the error message more useful to help identify what's wrong. As it is, the stack trace doesn't help.

🇺🇸United States j_s

@chetan-11 Thanks for getting it started! There's some more work needed, but I'm not sure how to work with that merge request.

Attached is a patch that adds more fixes after MR!1.

I'm also getting this deprecation notice but am unsure how to fix it:

Deprecated function: Implicit conversion from float 2551442.86108 to int loses precision in Drupal\moon_phases\MoonCalc->setPositionInCycle() (line 87 of modules/contrib/moon_phases/src/MoonCalc.php).

But that notice doesn't normally show unless you enable display errors or look at the log. I think this patch is ready for review, and that deprecation notice could be addressed in a future issue.

🇺🇸United States j_s

Any update on when this Drupal 10 version will become available? Thanks!

🇺🇸United States j_s

RobLoach is now a maintainer. Looking forward to seeing the update come through!

🇺🇸United States j_s

Still active as the proposed resolution of "Release the Insert View 2.1 release" is not yet fixed.

🇺🇸United States j_s

joshuasosa created an issue.

🇺🇸United States j_s

Also hoping to get this merged soon to have a Drupal 10 version.

🇺🇸United States j_s

Any idea when Drupal 10 version will be available in anything besides -dev?

Production build 0.71.5 2024